176765 - XML-RPC does not support https even though comment says it does

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

There is a comment in code that says we support http and https, but the code
checks only for http and throws for all other protocols. It should check and
allow https as well.

Comment 1

[Samuel Sieb]

Attachment: add https support

I assume this should work.  Does anyone have a server I could test it on?

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 104722 [details] [diff] [review]
add https support

r=heikki

You could test by trying to connect to any https server, and just see if you
can connect and get any data. Either use ngrep	or some such to sniff the
traffic or use alert or something to confirm that you receive some data.

Comment 3

[Tony Wells]

I added SSL support to my webserver, added the patch attached to nsXmlRpcClient.js
and tried an XML-RPC request to an Apache/PHP webserver over HTTPS.

It worked, I got data back fine.

Comment 4

[Mike Lee]

I can't super review can I? ;p But according to one of the mozblog users who use
https this works. 

Comment 5

[Darin Fisher]

Comment on attachment 104722 [details] [diff] [review]
add https support

sr=darin

Comment 6

[Samuel Sieb]

checked in