Closed
Bug 177054
Opened 22 years ago
Closed 20 years ago
fix all openers of the advanced ab search dialog to open a new dialog (if one is not already open), or raise the existing one (if it exists)
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sspitzer, Assigned: Stefan.Borggraefe)
Details
Attachments
(1 file)
|
2.96 KB,
patch
|
neil
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
On the trunk, Tools | Search | Search Addressess.. brings the top most search
dialog to focus, but in all other access points, we bring up a new search dialog.
we should make all openers act the same.
Currently, we appear to handle multiple search dialogs correctly.
We should ask jglick what she wants. Something to keep in mind is there might
be a compelling reason one day to just support one dialog, like there is for
mail search.
Unless there is a compelling reason to bring up a new search dialog instead of
giving focus to an existing, already open dialog, i'd recommend the more simple
ui of bringing forward the already open dialog.
|
Assignee | |
Comment 3•20 years ago
|
||
Assignee: sspitzer → Stefan.Borggraefe
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•20 years ago
|
Severity: normal → trivial
OS: Windows 2000 → All
Hardware: PC → All
|
|
Assignee | |
Updated•20 years ago
|
Attachment #150600 -
Flags: review?(neil.parkwaycc.co.uk)
|
||
Comment 4•20 years ago
|
||
Comment on attachment 150600 [details] [diff] [review]
Fixes both TB and SM
Nit: line up .getService with .classes
Attachment #150600 -
Flags: review?(neil.parkwaycc.co.uk) → review+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Comment on attachment 150600 [details] [diff] [review]
Fixes both TB and SM
I'll address Neil's nit before checkin. Asking Seth for sr, because he reported
this bug.
Attachment #150600 -
Flags: superreview?(sspitzer)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #150600 -
Flags: superreview?(sspitzer) → superreview?(mscott)
|
Reporter | |
Updated•20 years ago
|
Summary: fix all openers of the advanced ab search dialog to open a new dialog (even if one exists), or raise the existing one (if it exists) → fix all openers of the advanced ab search dialog to open a new dialog (if one is not already open), or raise the existing one (if it exists)
|
|
Reporter | |
Comment 6•20 years ago
|
||
Comment on attachment 150600 [details] [diff] [review]
Fixes both TB and SM
thanks for fixing this stefan.
sr=sspitzer for SM, but you will need a=mscott for tbird.
Attachment #150600 -
Flags: superreview?(mscott) → superreview+
|
|
Assignee | |
Comment 7•20 years ago
|
||
Thanks Seth! :-)
Scott, can you give moa for the TB part of this patch?
|
||
Comment 8•20 years ago
|
||
sure...looks good :)
|
|
Assignee | |
Comment 9•20 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•