177207 - Support dontchange generically in process_bug

Status: RESOLVED INVALID

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Christian Reis]

Today the dontchange parameter is only supported if mass changes are being
performed (in other words, if "id" is set, dontchange does nothing).

This makes it a bit less straightforward to write an external application to
interact with process_bug, and makes the conditionals more complicated, among
other things, and I don't really see a good reason why it shouldn't be simplified.

Patch coming up.

Comment 1

[Christian Reis]

Attachment: kiko_v1: support dontchange even if bug id present.

I've coded up a quick fix to this, and it worksforme. Gerv, you said you might
have a look at this?

Comment 2

[Gervase Markham [:gerv]]

Does this really work for you? :-)

+if (($::FORM{'id'} && $::FORM{'product'} ne $::oldproduct) 
+    && ( $::FORM{'product'} ne $::FORM{'dontchange'})

Surely if $::FORM{'id'} is not defined (the multi-change case), this if test
will never pass, and so the product will never change?

And I don't understand your change to CGI.pl either :-(

Gerv

Comment 3

[Christian Reis]

This fell off my plate and I don't feel it's worth keeping open since a better
solution would be beyond this hack.