177314 - Rhino should allow '\400' to mean ' 0'

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Igor Bukanov]

Although octal escapes in string literals are not part of Ecma 262 since the
version 3, to support old scripts Rhino should handle them correctly. In
particular, currently Rhino throws an error when evaluating
'\400' == ' 0'

js> '\400' == ' 0'
js: "<stdin>", line 1: uncaught JavaScript exception: SyntaxError: octal escape
too large (<stdin>; line 1)
js: '\400' == ' 0'
js: ....^

while SM gives true, which is what required by Ecma 262 version 1 and 2.

Comment 1

[Igor Bukanov]

Attachment: Assume 3-char octal escape only if the result <= 0377

The patch also removes msg.oct.esc.too.large from the resources as it is no
onger used

Comment 2

[Igor Bukanov]

I commited the above patch, as it passes the test suite and gives true '\400' ==
' 0'. The question is where to put a testcase for it?

Comment 3

[Phil Schwartau]

Testcase added to JS testsuite:

      mozilla/js/tests/js1_5/LexicalConventions/regress-177314.js

Comment 4

[Igor Bukanov]

Marking as fixed as the patch was commited.

Comment 5

[Phil Schwartau]

Marking Verified FIXED. 

Before the patch, Rhino errored on the testcase as described above.
Now, the testcase passes in both compiled and interpreted mode -

Comment 6

[Igor Bukanov]

Targeting as resolved against 1.5R4