17771 - LN,FN separated by comma in e-mail address results in splitting the name when Reply

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[esther]

Using 1999110109m11 build on win98, when I Reply to a message that has a
recipient with an e-mail address using LN,FN separated by a comma
(example:"Last, First" <[e-mail]>) the name splits after the
comma when doing a Reply.  I have (2) people who e-mail me with this format and
they both use Outlook Express.  4.7 can handle the comma.  I still need to check
Mac and linux.

0. Have someone with an e-mail address that fits the example above send you a
message.
1. Launch Messenger
2. Select the account this message would be in
3. Select the message and Click Reply

Result: the name before the comma is on the first line, the rest of the name and
e-mail address are on the second line.

Expected: the full name of the recipient on the first line.

Comment 1

[Jean-Francois Ducarroz]

Right, we use comma as recipient separator. We should probably use someting else? or put the full email address
between double quotes in this particular case.

Comment 2

[Phil Peterson]

You should use the utility functions we already have to parse a buffer of
recipients into the properly separated email addresses. Whatever the modern-day
equivalent of MSG_ParseRFC822Addresses is (I bet rhp knows) That code knows
about double quotes and RFC822 special characters.

Comment 3

[rhp (gone)]

Should be in:

http://lxr.mozilla.org/mozilla/source/mailnews/mime/public/nsIMsgHeaderParser.i
dl

- rhp

Comment 4

[Jean-Francois Ducarroz]

Looks like it will be more complex than expected. The addresses are broken in
unique entity at the Front end level therefore from JS. As from JS we deal only
with unicode data, I cannot use directly the msgHeaderParser function. I will
need to add a new scriptable class to wrap a nsString array which will
be constructed by msgCompose using the parser
function.

I have also discovered that we have some problem during the send when we use
comma into any recipient's address.

Comment 5

[Jean-Francois Ducarroz]

OK, I have a fix for that in my tree. Now we are supporting correctly any RFC822
recipients in a reply/reply all message. But we have now problem sending the
message with those specific formated (LN,FN) recipients. I am working on the
send issue now...

Comment 6

[Jean-Francois Ducarroz]

Fixed and checked in. Review by jefft

Comment 7

[esther]

Using build 1999120808 on mac and linux and build 1999120716m12 on win98 this is
fixed.  Verified

Comment 8

[sstock]

This bug still appears to exist in the linux build 2000040315.  I sent a
message with the following headers:

From: "Stock, Steve (from)" <[e-mail]>
To: "Stock, Steve (to)" <[e-mail]>
CC: "Lastname, Firstname" <[e-mail]>
Subject: test message

When I hit "reply all" the compose window had the following addresses:
To: "Stock, Steve (from)" <[e-mail]>
Cc: Stock
Cc: Lastname
Cc: Firstname <[e-mail]>

It appears that the From address is parsed correctly for the To field, but the
CC list is just wrong.  Other (real life :-) emails are also showing this behavior.

Let me know if you need more information.

Comment 9

[lchiang]

[e-mail] - pls open a new bug up for your case.  This bug report 
is pretty old so we don't want your comments to get lost.  Thanks!

Comment 10

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/b610b04e7bf7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17771: three-dot menu reorder (https://github.com/mozilla-mobile/fenix/pull/17838)