178067 - gtk2 FE requires xft enabled to compile

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

the following code in gfx/src/gtk/nsDeviceCOntextGTK.cpp is not wrapped inside
an ifdef MOZ_ENABLE_XFT:
  // try to get it from xft
  PRInt32 xftdpi = GetXftDPI();

  if (xftdpi)
    return xftdpi;

however GetXftDPI is in such an ifdef.

-> compilation fails.

attaching a suggested patch in a second

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

blizzard, could you review?

Comment 2

[Christopher Blizzard (:blizzard)]

Are there other parts of the gtk2 build that fail if you don't have Xft?  Gtk2
without xft support isn't going to be supported for much longer.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

no, the rest compiled fine.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

(and worked, too)

Comment 5

[Christopher Blizzard (:blizzard)]

Comment on attachment 104949 [details] [diff] [review]
patch

r=blizzard

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 104949 [details] [diff] [review]
patch

sr=bzbarsky

Comment 7

[Christopher Blizzard (:blizzard)]

-> [e-mail]

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

fyi, I sent mail to drivers asking for approval on 03.11.2002 18:37 CET.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 104949 [details] [diff] [review]
patch

a=[e-mail] for trunk

Comment 10

[Christopher Blizzard (:blizzard)]

Fixed.