178273 - Mis-sized file icon

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P2)

Description

[Matt Lee]

When clicking a link to a document file on a website or doing a Save Target As,
the dialog that appears, usually contains an icon for the particular file type. 

However, if the default icon size in Windows is increased to say 48x48, these
icons appear garbled.

I am using 1.2b

Comment 1

[Matthias Versen [:Matti]]

see also bug 108567

Comment 2

[Michael Lefevre]

Reporter (Matt): Can you reproduce this bug with a recent build of Mozilla (for
example, 1.3a)? If so, then please comment again with details. If not, then
please resolve this bug as WORKSFORME. Thanks.

Comment 3

[Matt Lee]

Attachment: Screenshot taken from 1.3a

Comment 4

[Matt Lee]

I have tried this in 1.3a and the problem is not resolved. Attached a screenshot.

Matt

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

>However, if the default icon size in Windows is increased to say 48x48

Hm, can that be done in Windows 2000 too? And if so, how?

Comment 6

[Michael Lefevre]

biesi - yes, and on Windows 98 as well I think.

standard icons are 32x32. in display properties (right click on desktop and
choose properties is easiest), the effects tab has a checkbox for "use large
icons", which gives 48x48 icons. if Windows is set to use large icons, Mozilla
takes the large (48x48) icon from Windows and displays a badly-rescaled 32x32
version.

I guess if the user has a high res screen and has set large icons, they would
probably want the large icon in the mozilla dialog too. confirming.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

michaell, thanks for your tip.

I can reproduce. let me investigate.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, and this is an imagelib bug really

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

sigh, this was hard to track down

I have a patch, will attach in a second

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

I guess I'll post the explanation about how the patch works here too:

The patch consists of two parts:
Firstly, the windows API is asked for a shell-sized icon (which respects the
user setting) instead of a "large" icon (which seems to be always 32x32)

Secondly, it fixes a bad assumption in the icon channel, which always assumed a
width of 32 bit (4 byte). That holds true for all icons below 32 pixels width,
because it is rounded up to a 4 byte boundary. For 48x48 icons, this needed to
be fixed.

Comment 12

[tor]

Comment on attachment 114135 [details] [diff] [review]
patch

sr=tor

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in win/nsIconChannel.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/win/nsIconChannel.cpp,v  <-- 
nsIconChannel.cpp
new revision: 1.23; previous revision: 1.22
done