178881 - nsNSSCertificate.cpp contains two non-localizable hardcoded strings

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Kai Engert [:KaiE:]]

NS_IMETHODIMP
nsNSSCertificate::GetNickname(nsAString &_nickname)
{
  if (isAlreadyShutDown())
    return NS_ERROR_NOT_AVAILABLE;

  const char *nickname = (mCert->nickname) ? mCert->nickname : "(no nickname)";
  _nickname = NS_ConvertUTF8toUCS2(nickname);
  return NS_OK;
}

NS_IMETHODIMP
nsNSSCertificate::GetEmailAddress(nsAString &_emailAddress)
{
  if (isAlreadyShutDown())
    return NS_ERROR_NOT_AVAILABLE;

  const char *email = (mCert->emailAddr) ? mCert->emailAddr : "(no email address)";
  _emailAddress = NS_ConvertUTF8toUCS2(email);
  return NS_OK;
}


The hardcoded strings should get moved to a string bundle.

Comment 1

[John G. Myers]

*** Bug 191378 has been marked as a duplicate of this bug. ***

Comment 2

[John G. Myers]

*** Bug 200639 has been marked as a duplicate of this bug. ***

Comment 3

[John G. Myers]

Attachment: Proposed fix

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 142316 [details] [diff] [review]
Proposed fix

sr=blizzard