179068 - String literals in Rhino are limited to 64K

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Igor Bukanov]

Currently Rhino does not support long string literals with more then 64K of
characters, which can be a problem to run it against automatically generated
scripts.

Comment 1

[Igor Bukanov]

Attachment: Test case

Test that the interpreter can handle string literals exceeding 64K limit. For
that the script passes to eval "str ='LONG_STRING_LITERAL';" where
LONG_STRING_LITERAL is a string with 200K chars.

Comment 2

[Igor Bukanov]

Attachment: Allow to use char sequences exceeding 64K when storing source for decompilation

The current 64K limit comes from omj/Parser.java where it constructs the
internal script presentation for future decompilation. The patch extends this
form to allow string sequences with more then 64K characters and modifes
decompilation code in omj/NativeFunction.java accordingly.

Comment 3

[Igor Bukanov]

Note that the above patch does not extend support for extremely long strings to
the compiler mode due to 64K limit on string in Java classfile format, but at
least with interpreter mode a Java-based browser can support a generate HTML
containing

<script>
...
document.write('HTML CODE WITH MORE THEN 64K CHARACTERS');
...
</script>

Comment 4

[Phil Schwartau]

Testcase added to JS testsuite:

      mozilla/js/tests/js1_5/String/regress-179068.js

Comment 5

[Igor Bukanov]

I commited the fix

Comment 6

[Phil Schwartau]

Marking Verified FIXED.

The above testcase used to fail in Rhino; now it passes in both
compiled and interpreted mode on WinNT -

Comment 7

[Igor Bukanov]

Targeting as resolved against 1.5R4