179084 - Bookmark Export uses Unix carriage returns on all platforms

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Adam Kennedy]

When exporting bookmarks under Windows ( XP in this case, but presumably all
Windows ), the bookmark .html file generated uses Unix carriage returns.

Unless I'm mistaken, it should use native carriage returns for generated
files... right?

Comment 1

[Adam Kennedy]

Now that I think about it, you should probably check OS X as well, in case it's
present across all non-Unix platforms.

Comment 2

[Jean-Pierre Melkonian]

Confirmed on MAC OS 9.1, Build 2002110408

Comment 3

[Adam Kennedy]

Satified it's not just Windows, adjusting subject and Platform/OS accordingly

Comment 4

[Frank Wein [:mcsmurf]]

We need to insert some code like in 
http://lxr.mozilla.org/mozilla/source/content/base/src/nsPlainTextSerializer.cpp#183
and following lines and probably insert in nsBookmarksService::WriteBookmarks
(or in nsBookmarksService::Init?). But this would change the whole bookmark
writing thing and I'm not sure if Mozilla supports reading bookmarks with other
linebreaks properly. So someone knows if this is possible?

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: very easy patch

well replaces \n with NS_LINEBREAK

Comment 6

[jag (Peter Annema)]

Comment on attachment 126839 [details] [diff] [review]
very easy patch

Seems good. Make sure this is tested on Mac, Unix and Windows to not break
anything and that all \n have been caught.

Comment 7

[Jan Varga [:janv]]

Comment on attachment 126839 [details] [diff] [review]
very easy patch

looks good and I confirm what jag said

Comment 8

[Frank Wein [:mcsmurf]]

Ok someone tested this patch on Linux a little bit longer and someone on mac os
x and both said the patch works ok.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsBookmarksService.cpp;
/cvsroot/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp,v  <-- 
nsBookmarksService.cpp
new revision: 1.295; previous revision: 1.294
done