179129 - MfcEmbed: about: url does not work

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[dsirnapalli]

about: does not work in current trunk mfcembed build.(2002-11-08-08-trunk).
got the error
XML Parsing Error: undefined entity
Location:jar:resource:///chrome/embed.jar!/locale/en-US/global/about.xhtml
Line Number 70, Column 1:
<a href="&vendorURL;">

Comment 1

[Adam Lock]

*** Bug 179134 has been marked as a duplicate of this bug. ***

Comment 2

[amutch]

I think the cause of the error is that about.xhtml can't find the "region.dtd" 
file declared at the top of about.xhtml:

<!ENTITY % regionDTD SYSTEM "chrome://global-region/locale/region.dtd" >

The contents of region.dtd includes:

<!-- brand.dtd -->
<!ENTITY  vendorURL             "http://www.mozilla.org/">
<!ENTITY  releaseURL            "http://www.mozilla.org/releases/">
<!ENTITY  getNewThemesURL       "http://mozilla.org/themes/download/">
<!ENTITY  content.version       "1.2">

which would supply the necessary vendorURL info.

In Mozilla, region.dtd is stored in US.jar. So, that needs to be pulled into 
embed.jar. 

Comment 3

[Adam Lock]

Grabbing ownership, patch coming...

Comment 4

[Adam Lock]

Attachment: Patch

Patch adds the missing global-region dirs and removes a
"locale,insert,select,en-US" that stops "US" locale files from loading.

Comment 5

[Adam Lock]

Comment on attachment 135838 [details] [diff] [review]
Patch

Requesting r/sr on this simple patch to fix the about: protocol in embedding

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 135838 [details] [diff] [review]
Patch

sr=jst

Comment 7

[Adam Lock]

Comment on attachment 135838 [details] [diff] [review]
Patch

Requesting 1.6 approval. Simple embedding specific fix for the long-broken
about: protocol

Comment 8

[chris hofmann]

Comment on attachment 135838 [details] [diff] [review]
Patch

a=chofmann for 1.6b

Comment 9

[Adam Lock]

Fix is checked in