179671 - Boolean charts are broken on reporting pages

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Gervase Markham [:gerv]]

They are broken in two ways:
- There's no list of fields
- Asking for AND or OR submits to report.cgi, which doesn't understand it, and
so throws the error "no axes defined".

Gerv

Comment 1

[Gervase Markham [:gerv]]

Fixed by bug 180205.

Gerv

Comment 2

[Rob Siklos [:robzilla]]

this bug seems to have re-appeared in 2.17.6 (at least).  

there is a list of fields, but clicking on "AND" or "Add new boolean chart" 
breaks the whole thing.

It happens on bugzilla.mozilla.org, as well as in my own 2.17.7.  Can someone 
re-open?

Comment 3

[Rob Siklos [:robzilla]]

the fix is to modify report.cgi and take the "\n\n" out of $location in the 
redirect part at the top.

Comment 4

[Dave Miller [:justdave]]

doh.  he's right. :)  Thanks, Rob!

Comment 5

[Dave Miller [:justdave]]

Attachment: Patch v1

Comment 6

[Gervase Markham [:gerv]]

This doesn't seem to fix the problem for me. Both before and after, I get:

"The requested format table does not exist with a content type of html."

Rob: is that the error you were seeing?

Gerv

Comment 7

[Rob Siklos [:robzilla]]

(In reply to comment #6)
Perhaps this fixes a different error altogether.  The problem I was seeing 
was "malformed header" in the apache2 error_log.

Comment 8

[Rob Siklos [:robzilla]]

Here's how to fix the "The requested format table does not exist with a content 
type of html" error:

In search/form.html.tmpl, change:

<input type="hidden" name="query_format" value="[% format FILTER html %]">

to

[% thisformat = query_format != '' ? query_format : format %]
<input type="hidden" name="query_format" value="[% thisformat FILTER html %]">

Comment 9

[Gervase Markham [:gerv]]

Rob: thanks!

Dave: do you want to add something like that to your patch?

Gerv

Comment 10

[Dave Miller [:justdave]]

Gerv: Sure, go for it.

Comment 11

[Dave Miller [:justdave]]

Attachment: Patch v2

Comment 12

[Jouni Heikniemi]

Comment on attachment 149608 [details] [diff] [review]
Patch v2

>Index: template/en/default/search/form.html.tmpl
>===================================================================
>-<input type="hidden" name="query_format" value="[% format FILTER html %]">
>+[% thisformat = query_format != '' ? query_format : format %]
>+<input type="hidden" name="query_format" value="[% thisformat FILTER html %]">

I'd love to forget the temp variable and just say |[% (query_format or format)
FILTER html %]|, but whatever pleases you most.

r=jouni

Comment 13

[Dave Miller [:justdave]]

Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.24; previous revision: 1.23
done
Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v 
<--  form.html.tmpl
new revision: 1.24; previous revision: 1.23
done

Comment 14

[Rob Siklos [:robzilla]]

*** Bug 249134 has been marked as a duplicate of this bug. ***