179760 - Classic theme uses system foreground color, but not system background color, sometimes resulting in bad color combinations

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Paul Baker]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.3a) Gecko/20021112
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.3a) Gecko/20021112

There are several theme programs out for Mac OS X. One of them being Duality
from Conundrum Software. <http://conundrumsoft.com/Duality/duality.html>

If you install a theme that changes the system menu text color to white (such as
the windows xp theme) this causes white on white text to happen on the bookmarks
and pop-up menus when using the Classic theme of mozilla.

The problem is that the Classic theme is honoring the system menu color (which
is probably the correct behaviour) but it does not honor the background of the
menu. In the case of the Windows XP theme, it is that rich windows xp blue
color. If mozilla should honor the blue so that popups and bookmark menus are
readable.

Reproducible: Always

Steps to Reproduce:
1. Install Duality.
2. Choose the Windows XP theme.
3. Open the bookmarks menu or any pop-up menu.

Actual Results:  
The menu's appear to be blank because the menu items' white text can not be
distinguished from the white background of the menu. Disabled menu options do
show up since they have a light grey text. Doesn't really do any good...they are
disabled.

Expected Results:  
The menu should use the correct background of the theme instead of just plain
white. In the case of the windows xp theme, the background should be blue.

I will attach screen shots.

Comment 1

[Paul Baker]

Attachment: apple menu with blue background (what menus should look like)

Comment 2

[Paul Baker]

Attachment: bookmarks menu with white on white text

Comment 3

[Paul Baker]

Attachment: pop-up menu with white on white text

Comment 4

[Greg K.]

Dup of/related to bug 66829?

Comment 5

[Greg K.]

Paul, can you still reproduce this problem using a current nightly build? If so,
are you applying Duality while Mozilla is running, and if so, does it work if
you quit Mozilla and relaunch it?

Comment 6

[Paul Baker]

still reproduceable in mach-o build 2003021803. duality applied with mozilla not
running. rebooting does not make a difference. took some new screenshots.

Comment 7

[Paul Baker]

Attachment: bookmark menu from the menubar (good - white on blue)

Comment 8

[Paul Baker]

Attachment: bookmarks menu from personal bar (bad - white on white)

Comment 9

[Greg K.]

So it seems Mozilla uses the system foreground color, but not the system
background color. Moz should either use both, or neither.

Paul, please test Modern also and let us know if this is a Classic-only problem.

Comment 10

[Paul Baker]

Attachment: bookmarks menu from personal bar (modern theme)

looks like the modern theme overrides both the foreground color and the
background color which creates black on that lightish-darkish-blueish color. So
this looks to be a classic theme only problem.

Comment 11

[Greg K.]

Marking confirmed on behalf of reporter and reassigning to Themes.

Comment 12

[Stefan [:stefanh]]

I think the patch in bug 301105 will take care of this.

Comment 13

[Stefan [:stefanh]]

This should be fixed now by the patch in bug 301105.