180346 - Impl new interfaces for external spell checkers

Status: RESOLVED INVALID

(Core :: Spelling checker, defect)

Description

[rods (gone)]

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Can you explain what this is about?

Comment 2

[rods (gone)]

I have a new set of interfaces based on David Einsteins work that will enable
external spell checkers to work within  Mozilla. The default spell checker will
still be our SC for Netscape. But David said he would port his MySpell over to
work with Mozilla so then Mozilla will have a spell checker.

Comment 3

[Chan Min Wai]

oh so what did you need on that.

Comment 4

[rods (gone)]

Attachment: New SpellCheck Interfaces

These are the new interfaces for enabling Mozilla to work with external
spellcheckers

Comment 5

[rods (gone)]

Attachment: patch (interfaces and new glue code)

Here are the interfaces with what I hope is the correct MPL and the new glue
code for mozilla.

Comment 6

[rods (gone)]

Attachment: SpellCheck Diagram

Diagram of the object hierarchy

Comment 7

[Aleksey Nogin]

Is bug 58615 a dup of this one? Bug 56301 comment #234 seems to imply that it is.

Comment 8

[rods (gone)]

*** Bug 58615 has been marked as a duplicate of this bug. ***

Comment 9

[Greg K.]

Is this relevant to bug 86886?

Comment 10

[rods (gone)]

Greg, what this means is that someone can now provide and impl of the apple
spellcheck to these new interfaces.

Comment 11

[Greg K.]

Thanks, rods. Sounds like this should be All/All.

Comment 12

[rods (gone)]

Comment on attachment 106525 [details] [diff] [review]
patch (interfaces and new glue code)

The interfaces are fine, I am obsoleting this because I have made some
significant changes to some of the glue code and I don't want this patch to be
reviewed. Plus, I think I will be moving this to the "extensions" directory.

Comment 13

[rods (gone)]

Attachment: new spellcheck directory in extensions

Comment 14

[rods (gone)]

Attachment: Changes to editor directory

Comment 15

[rods (gone)]

Attachment: debug pref panel changes

Comment 16

[rods (gone)]

reassigning

Comment 17

[rods (gone)]

taking back

Comment 18

[rods (gone)]

Attachment: patch

This patch contains only the changes for splitting the glue code apart and
being able to spellcheck an arbitrary selection

Comment 19

[Simon Fraser [no longer active]]

+#ifdef XP_MAC
+#define IS_NBSP_CHAR(c) (((unsigned char)0xca)==(c))
+#else
+#define IS_NBSP_CHAR(c) (((unsigned char)0xa0)==(c))
+#endif

That might need to be 
#if defined(XP_MAC) || defined(XP_MACOSX)

Comment 20

[rods (gone)]

Attachment: patch for config files

These files will put the mozilla/extensions/spellcheck into the build

Comment 21

[[e-mail]]

Rod, 

what is the status on this bug? Can we start porting mozdev's spell checker to
the new glue code?

Comment 22

[Daniel Jensen]

Any chance of this going in during the 1.4 cycle?

Comment 23

[Simon Spiegel]

Has the now Mozilla roadmap any influence on this bug? Will 
Minotaur/Thunderbird/Moz1.5 ship with a spellchecker? AFAIK additions/plugins 
should be easier to handle with the new approach. Will the spellchecker remain a 
mozdev addon, or will it once be part of the distribution?

Comment 24

[Aleksey Nogin]

Now that mozdev spellchecker is in the tree, is this bug still relevant?

Comment 25

[:Gavin Sharp [email: [e-mail]]]

I'm pretty sure this is no longer valid.