180577 - [RFE] color codes can be seen but not inserted

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement)

Description

[Wilhelm Svenselius]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021115
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021115

There's no way that I've found to insert color codes while typing a message in
Chatzilla. In mIRC and Klient (to mention two examples) a small color picker can
be brought up by pressing Ctrl-K. This then inserts the (mIRC-compatible)
control code for the selected color into the message at the cursor position. It
would be nice to have this functionality in Cz. Oh, and throw in the codes for
bold and underline too, while you're at it.

Reproducible: Always

Steps to Reproduce:
1. Try to use mIRC-style colors or bold/underline codes in your messages while
using Cz, using a convenient built-in color picker.

Actual Results:  
Nothing.

Expected Results:  
Something similar to the way established IRC clients like mIRC and Klient handle
insertion of color and bold/underline codes.

Comment 1

[Koike Kazuhiko]

Attachment: patch v1

This patch lacks a color picker, but users can insert color codes
like xchat.

%U: underline
%B: bold
%R: reverse
%O: normal
%C: color   ex. %C4 = red, %C8 = yellow

Comment 2

[Samuel Sieb]

Comment on attachment 119168 [details] [diff] [review]
patch v1

This is great, but it needs a pref (defaulting to off).  Under Global Options
in the main pref pane add something like "Enable color code escape characters".

Comment 3

[Koike Kazuhiko]

Attachment: patch v2

Added "extensions.irc.colorCodes" and a checkbox in the preferences
dialog.

We already have "extensions.irc.munger.colorCodes". Isn't it confusing?
Should I rename these prefs?

Comment 4

[Samuel Sieb]

Comment on attachment 119347 [details] [diff] [review]
patch v2

r=[e-mail] with changes to the replacements to make them global (I made
the changes)

Comment 5

[Samuel Sieb]

checked in

Comment 6

[Samuel Sieb]

This doesn't work for /me actions.

Comment 7

[James Ross]

Just a little note; I can't enter a raw % with this turned on.

E.g. I want to actually type "%C" (for example, as part of something else) and
can't.

Comment 8

[Koike Kazuhiko]

Attachment: patch v3

(1) replaces color codes in /me command
(2) doesn't replace '%%B' or '%%U'

Comment 9

[David Perry]

I've done a little work on an onkeypress handler for the inputs that would pop
up a colour guide in a tooltip.  Would that sort of thing be desirable?

Comment 10

[David Perry]

Attachment: Pop-up character/colour guide v1

Applied against vanilla chatzilla 0.8.26.  This adds an onkeypress handler to
the two textbox inputs (oninput would be ideal, but didn't work for me).  If
the last character typed is a %, it pops up a tooltip describing %[UBROC%].  If
the last few characters look like a %C colour code, it's a tooltip showing the
colour codes.

What the heck, I was bored.

Comment 11

[David Perry]

Doh... line 65 of my patch should have "color:white" in place of
"background-color:white".  It's late.

Comment 12

[James Ross]

Wow... just tried that pop-up patch - very neat. :)  I see no reason that can't
go into ChatZilla.

Comment 13

[Samuel Sieb]

This has been fixed in recent versions.