Closed Bug 18075 Opened 26 years ago Closed 26 years ago

Leaving incoming server blank causes several crashes

Categories

(SeaMonkey :: MailNews: Account Configuration, defect, P3)

Product:
SeaMonkey
Component:
MailNews: Account Configuration
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED WORKSFORME

People

(Reporter: tonyr, Assigned: scottputterman)

References

Details

(Keywords: crash)

Create a new account and leave the incoming server field blank (empty). This causes several crashes - the best thing to do is try it and see. Some of the crashes were: In nsMsgFolder.cpp, line #162: if (NS_SUCCEEDED(rv) && (const char*)userName) Should be: if (NS_SUCCEEDED(rv) && (const char*)hostName) There are other references to the incoming server hostName that cause various crashes and asserts. Open the Account Setup dialog and click on the account with no incoming server and you'll hit the other crashes. It's possible the fix is to default the incoming server to something but it would probably be good to fix up the code regarding a null hostName first.
QA Contact: lchiang → nbaca
Hardware: PC → All
Status: NEW → ASSIGNED
Target Milestone: M12
this should be easy to fix.
Blocks: 18190
release noted for M11.
*** Bug 18280 has been marked as a duplicate of this bug. ***
seth checked the above fix in yesterday. I need to make another run at it and see wherelse we crash.
*** Bug 19396 has been marked as a duplicate of this bug. ***
Assignee: alecf → putterman
Status: ASSIGNED → NEW
Scott, could you look at this?
Status: NEW → ASSIGNED
What else is left with this bug? I see that we crash when doing GetNewMessages on a server with no host. cc'ing mscott about this. I know why. In this case nsMsgProtocol::OpenNetworkSocket will return a failure error. However because this is happening in nsPop3Protocol::nsPop3Protocol the error code is not propagated outwards. The solution here would be to make Initialize get called by whoever allocates the nsPop3Protocol so that the error code can be used. I haven't checked to see if this happens on news and imap accounts as well.
Is this bug going to move to M13?
I think the critical part of this bug has been fixed by alec in the past. I have a fix for pop GetMsgs when this happens but don't have a fix for Imap yet.
I'll move to M13 at midnight tomorrow if I still don't get to it.
I fixed it so that local accounts with no incoming servers no longer crash when doing GetMsg. Moving but to M13 for Imap.
doh, we must have been working on the same fix at the same time, I just sent off a patch to mscott for review :)
Target Milestone: M12 → M13
really moving remainder of bug to M13.
Build 2000011008M13: NT4, Linux 6.0, Mac 8.5.1 Account Wizard now requires the name of the Incoming Server to continue through the dialogs. If it is left blank and the Next button is selected then it states "please enter a valid hostname".
Blocks: 24206
Target Milestone: M13 → M15
This isn't as urgent now that the account manager won't allow this. changing to M15.
Adding "crash" keyword to all known open crasher bugs.
Keywords: crash
Mass moving to M16 to get these off the M15 radar. Please let me know if this is really an M15 stopper.
Target Milestone: M15 → M16
moving to M20. I don't think this is a major issue anymore.
Target Milestone: M16 → M20
Build 2000-04-14-10M16: NT4 Build 2000-04-14-09M16: Linux 6.0 1. OK on Windows and Linux. In the Account Wizard's Server dialog I tried selecting the Next button without entering anything and it warns that you must enter a server name. Then I hit the space bar and was able to go to the Next dialog. After the account was created I tried retrieving messages for POP and IMAP and no problems occured. It did warn that it was not able to connect to the server. 2. Build 2000-04-14-11M16: Mac 8.5.1 It doesn't crash but after the account is created go to Get Messages and the Status Bar states "Document Done" with the horizontal scrollbar moving continuously. I can switch to another account and read messages so it's still useable. Expected Results: On the Mac I would have expected the error message to appear stating that it was unable to connect to the server (same as Win and Linux). Should we close this and open a new bug specific to the Mac problem? I'll also log a bug on the Account Wizard to do more checking so that it checks for spaces.
Actually, if you can't make it crash by making the incoming server a space (" ") then this bug is probably worksforme, and we do probably need the other two bugs.
Marking Worksforme.
Marking Worksforme again.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → WORKSFORME
Verified Worksforme. If anyone else can duplicate this then please reopen.
Status: RESOLVED → VERIFIED
No longer blocks: 24206
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.