180901 - Sending with only BCC recepients also sends to ME

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[David Hagood]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021118
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021118

When forwarding a bunch of spam to BCC:spamcop and BCC:[e-mail], the messages
also get send to my address as well. I've verified that I DON'T have the mail
system set to auto-send messages to me, and I don't see this behavior if I send
a normal message (i.e. one that has at least one recipent that is not BCC'ed).

Reproducible: Always

Steps to Reproduce:
1. Compose email
2. Set recipent lists to just BCC - not CC or TO
3. Send mail

Actual Results:  
Mail is sent to BCC list, and to sender's address.

Expected Results:  
As per older Mozillas, mail should just be sent to the BCC addresses.

Comment 1

[Jean-Francois Ducarroz]

This is a new behavior to prevent some poor mail server to reveal BCC recepient
when no TO or CC are specified. It's a trade of we had to take. Why not
forwarding your spam using TO or cc?

Comment 2

[David Hagood]

At a minimum, it would be best (IMHO) if Mozilla were to warn you that it was
going to add an email to the mail, and why.

In the case I list, Spamcop gets "confused" if it sees any other recipents of
the mail, and it is possible that [e-mail] might as well, hence why I BCC
everybody.

I started getting my (rather lengthy) spam reports seemingly bounced back to me
for no obvious reason, and no obvious explaination as to why.

At least if Mozilla popped up a dialog saying "I'm going to add you, since some
buggy mailers might puke on this" would have given me a clue as what is going on.

Comment 3

[Jean-Francois Ducarroz]

I'll see if I can add a (hidden) pref to disable this feature...

Comment 4

[esther]

This is the workaround for bug fix to 16499. Resolving as assigned since
jean-francoise is looking into a hidden pref 

Comment 5

[Jean-Francois Ducarroz]

accepting, despite Esthere still doesn't know how to write my name :-)

Comment 6

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v1

Add a pref (no ui) to disable auto-addressing when no recipient are disclosed

Comment 7

[Jean-Francois Ducarroz]

Comment on attachment 107515 [details] [diff] [review]
Proposed fix, v1

if somebody has a better name for the pref, I am fully open...

Comment 8

[Cavin Song]

Comment on attachment 107515 [details] [diff] [review]
Proposed fix, v1

r=cavin.

Comment 9

[David :Bienvenu]

how about just "send_to_self_when_no_disclosed_recipients"

Comment 10

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v2

I went back to my copy and decide to reimplement this feature like I should
have done the first time by addressing the message to an empty group named
undisclosed-recipients instead of addressing it to the sender. I put also a
preference just in case! I haven't did that in first place because I touhgt my
mailserver has trouble handling empty groups but it was in fact a problem on
the Mozilla side (group need to be undone before handing the list of recipient
to SMTP). The proposed fix will make Mozilla supports empty groups. Mozilla
still have problem with non empty group but that is out of the scope of this
bug

Comment 11

[Cavin Song]

Comment on attachment 107618 [details] [diff] [review]
Proposed fix, v2

r=cavin.

Comment 12

[David :Bienvenu]

Comment on attachment 107618 [details] [diff] [review]
Proposed fix, v2

+    aChar = *readPtr;
+    readPtr ++;
can just be:
aChar = *readPtr++

and we talked about having a better comment about the input syntax for
UndoAddressGroup

Comment 13

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v3

I addressed bienvenu's comment received by AIM. Rename a function and add
better comment.

Comment 14

[Jean-Francois Ducarroz]

Comment on attachment 107920 [details] [diff] [review]
Proposed fix, v3

carry over R=cavin

Comment 15

[David :Bienvenu]

Comment on attachment 107920 [details] [diff] [review]
Proposed fix, v3

sr=bienvenu

Comment 16

[Jean-Francois Ducarroz]

Fix checked in the trunk. Now, when no recipient is disclosed, the message is
addressed to an empty group named undisclosed-recipients if the pref
"mail.compose.add_undisclosed_recipients" is set to true (true by default).