180942 - Helper Applications panel: buttons/groupbox partially cropped on right side

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[sairuh (rarely reading bugmail)]

spun off from bug 138680. the buttons in the Helper Applications prefs panel are
partially cropped.

screenshot coming up.

Comment 1

[sairuh (rarely reading bugmail)]

forgot to add: even though the upcoming screenshot was done on linux (rh7.2,
2002.11.19.04 trunk), this is seen on other platforms like mac.

Comment 2

[sairuh (rarely reading bugmail)]

Attachment: screenshot of pref panel on linux

Comment 3

[Bill Strohm]

Attachment: Screenshot of Helper Apps on Mac under OS 9.2.2

Attachment shows Mozilla 1.2b (and Netscape 7.0) Helper Apps dialog box under
Mac OS 9.2.2, with parish's patch applied which fixed Bug 138680. Several other
dialog boxes have cut-off radio buttons - this is just an example of one.

Comment 4

[Samir Gehani]

Nav triage team: nsbeta1+/adt2

Comment 5

[sairuh (rarely reading bugmail)]

this is a bit better using 2003.01.13.08 comm trunk builds. on some
platforms/themes, there's still cropping, but on my machines (at least) it
appears limited to clipping of the groupboxes on the righthand side.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Well, I looked into why there is still cropping.  All the helper app stuff is
resizable just fine down to very small sizes.  The PFS blurb at the bottom is
not, however (specifically, the over-wordy checkbox label cannot wrap).  I still
fail to understand why it's in this preference panel and would like it to be
removed; failing that I would like the people who added it to make it not break
the pref panel.

Since none of those people ever fix anything, doron has volunteered to take this
bug.

Comment 7

[Doron Rosenberg (IBM)]

just as I expected - <hbox> was causing the wrapping to not happen.

Comment 8

[Doron Rosenberg (IBM)]

Attachment: trivial - remove the useless <hbox>

simple patch - remove the hbox.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 111954 [details] [diff] [review]
trivial - remove the useless <hbox>

ship it.

Comment 10

[Doron Rosenberg (IBM)]

anyone want to check it in?

Comment 11

[Doron Rosenberg (IBM)]

timeless checked it in,didn't mark this bug so. naughty 

Comment 12

[Pascal Chevrel:pascalc]

*** Bug 190113 has been marked as a duplicate of this bug. ***

Comment 13

[sairuh (rarely reading bugmail)]

vrfy'd fixed on win2k, linux rh8.0 and mac 10.2.3.