Closed Bug 18133 Opened 26 years ago Closed 26 years ago

[FEATURE][REGRESSION] some keyboard shortcuts aren't working

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: Brade, Assigned: saari)

References

Details

Keyboard shortcuts used to work. They don't work today (or recently). I expect to type "Command-O" on a Macintosh and open a window. (browser or composer). I tested Windows and Macintosh.
Summary: keyboard shortcuts aren't working → [REGRESSION] keyboard shortcuts aren't working
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Fixed. There are other problems in editor that seem to be content model consruction/broadcaster hookup related. The case you state works again.
did you check something in today or are you claiming this is already fixed now? Just wondering because 1999111608 builds do not show any fix.
i may have a fix for this. there was a XUL problem.
*** Bug 18594 has been marked as a duplicate of this bug. ***
Status: RESOLVED → REOPENED
Reopening so it stays on the proper radar. *I've noticed that the listeners don't even fire when you press Ctrl-O UNLESS you've already accessed one of those dialogs. Only then is onkeypress= and oncommand= echoed to the console -even though they stil don't work.
*** Bug 18611 has been marked as a duplicate of this bug. ***
Resolution: FIXED → ---
clearing the fixed resolution
*** Bug 19503 has been marked as a duplicate of this bug. ***
Priority: P3 → P2
Summary: [REGRESSION] keyboard shortcuts aren't working → [REGRESSION] some keyboard shortcuts aren't working
Target Milestone: M13
targetting p2 for m13, most work using today's comm opt bits, <MOD>-O and <MOD>-E seem to be the main exceptions.
Component: XP Toolkit/Widgets → XPMenus
QA Contact: claudius → sairuh
reassigning QA to me and updating component.
Menus need to be pulled down before things work. There are many variations of this bug floating around.
Priority: P2 → P1
Summary: [REGRESSION] some keyboard shortcuts aren't working → [FEATURE][REGRESSION] some keyboard shortcuts aren't working
Waterson, I'm going to make this the primary bug for all of the duplicates
Assignee: saari → waterson
Status: REOPENED → NEW
Waterson, I'm actually assigning this to you.
*** Bug 20271 has been marked as a duplicate of this bug. ***
Assignee: waterson → saari
you and hyatt are the ones banging around in the code now. don't give -me- the bug! it worked until, uh, *YOUR* focus and key binding landed!!!
Status: NEW → ASSIGNED
Ok... So the only way I can see that Hyatt/myself could have broken this would have been with the keybindings loading later, when a key is pressed. Maybe we missed a step with hooking broadcasters up? I don't know that part of the code very well at all.
I believe this was fixed with my latest checkin.
No, it is still broken
Status: ASSIGNED → RESOLVED
Closed: 26 years ago → 26 years ago
Resolution: --- → FIXED
This does indeed look to be fixed now. Command-O on mac brings up the file dialog. Command-N a new browser. I thought this was still broken because I'd been using Command-H for Home and that wasn't working. Turns out that is a problem in the XUL itself.
Status: RESOLVED → VERIFIED
verified as fix using mac comm bits from 2000-011310.
Blocks: 24206
BULK MOVE: Changing component from XP Menus to XP Toolkit/Widgets: Menus. XP Menus component will be deleted.
Component: XPMenus → XP Toolkit/Widgets: Menus
No longer blocks: 24206
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: bugzilla → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.