181334 - AIX: libgfxft2.so fails to link

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Philip K. Warren]

With the checkin for Bug 144664, libgfxft2.so fails to link on AIX with the
following errors:

/usr/vacpp/bin/makeC++SharedLib_r -ldl -p1 -brtl -bso -bsymbolic -bnortllib -o
libgfxft2.so  nsFreeType.o    -brtl -bso -bh:5          -lC_r -ldl -lm -lc_r    
ld: 0711-317 ERROR: Undefined symbol: nsACString::GetImplementationFlags() const
ld: 0711-317 ERROR: Undefined symbol: nsACString::GetFlatBufferHandle() const
ld: 0711-317 ERROR: Undefined symbol: nsACString::GetBufferHandle() const
ld: 0711-317 ERROR: Undefined symbol: nsACString::GetSharedBufferHandle() const
ld: 0711-317 ERROR: Undefined symbol: nsASingleFragmentCString::Length() const
ld: 0711-317 ERROR: Undefined symbol: nsACString::IsVoid() const
ld: 0711-317 ERROR: Undefined symbol: nsACString::SetIsVoid(int)
ld: 0711-317 ERROR: Undefined symbol: nsACString::Cut(unsigned int,unsigned int)
ld: 0711-317 ERROR: Undefined symbol: nsACString::do_AssignFromReadable(const
nsACString&)
ld: 0711-317 ERROR: Undefined symbol: nsACString::do_AssignFromElementPtr(const
char*)
ld: 0711-317 ERROR: Undefined symbol:
nsACString::do_AssignFromElementPtrLength(const char*,unsigned int)
ld: 0711-317 ERROR: Undefined symbol: nsACString::do_AssignFromElement(char)
ld: 0711-317 ERROR: Undefined symbol: nsACString::do_AppendFromReadable(const
nsACString&)
ld: 0711-317 ERROR: Undefined symbol: nsACString::do_AppendFromElementPtr(const
char*)
ld: 0711-317 ERROR: Undefined symbol:
nsACString::do_AppendFromElementPtrLength(const char*,unsigned int)
ld: 0711-317 ERROR: Undefined symbol: nsACString::do_AppendFromElement(char)
ld: 0711-317 ERROR: Undefined symbol: nsACString::do_InsertFromReadable(const
nsACString&,unsigned int)
ld: 0711-317 ERROR: Undefined symbol: nsACString::do_InsertFromElementPtr(const
char*,unsigned int)
ld: 0711-317 ERROR: Undefined symbol:
nsACString::do_InsertFromElementPtrLength(const char*,unsigned int,unsigned int)
ld: 0711-317 ERROR: Undefined symbol:
nsACString::do_InsertFromElement(char,unsigned int)
ld: 0711-317 ERROR: Undefined symbol:
nsACString::do_ReplaceFromReadable(unsigned int,unsigned int,const nsACString&)
ld: 0711-317 ERROR: Undefined symbol:
nsASingleFragmentCString::GetReadableFragment(nsReadableFragment<char>&,nsFragmentRequest,unsigned
int) const
ld: 0711-317 ERROR: Undefined symbol:
nsASingleFragmentCString::GetWritableFragment(nsWritableFragment<char>&,nsFragmentRequest,unsigned
int)
ld: 0711-317 ERROR: Undefined symbol:
.nsHashtable::Reset(int(*)(nsHashKey*,void*,void*),void*)
ld: 0711-317 ERROR: Undefined symbol: .nsDebug::Assertion(const char*,const
char*,const char*,int)
ld: 0711-317 ERROR: Undefined symbol: .nsHashtable::nsHashtable(unsigned int,int)
ld: 0711-317 ERROR: Undefined symbol: .nsCStringKey::nsCStringKey(const
char*,int,nsCStringKey::Ownership)
ld: 0711-317 ERROR: Undefined symbol: .nsHashtable::Put(nsHashKey*,void*)
ld: 0711-317 ERROR: Undefined symbol: .nsCStringKey::~nsCStringKey()
ld: 0711-317 ERROR: Undefined symbol: .nsCAutoString::nsCAutoString(const char*)
ld: 0711-317 ERROR: Undefined symbol: .ToLowerCase(nsCString&)
ld: 0711-317 ERROR: Undefined symbol: .nsCStringKey::nsCStringKey(const
nsAFlatCString&)
ld: 0711-317 ERROR: Undefined symbol: .nsDebug::Error(const char*,const char*,int)
ld: 0711-317 ERROR: Undefined symbol: .PR_UnloadLibrary
ld: 0711-317 ERROR: Undefined symbol: .nsCOMPtr_base::assign_from_helper(const
nsCOMPtr_helper&,const nsID&)
ld: 0711-317 ERROR: Undefined symbol:
__vft24nsGetServiceByContractID15nsCOMPtr_helper
ld: 0711-317 ERROR: Undefined symbol: .nsCOMPtr_base::~nsCOMPtr_base()
ld: 0711-317 ERROR: Undefined symbol: .nsDebug::PreCondition(const char*,const
char*,const char*,int)
ld: 0711-317 ERROR: Undefined symbol: .nsXPIDLCString::GetSharedEmptyBufferHandle()
ld: 0711-317 ERROR: Undefined symbol: __vft14nsXPIDLCString10nsACString
ld: 0711-317 ERROR: Undefined symbol: .nsXPIDLCString::PrepareForUseAsOutParam()
ld: 0711-317 ERROR: Undefined symbol:
.nsCOMPtr_base::assign_with_AddRef(nsISupports*)
ld: 0711-317 ERROR: Undefined symbol: __vft13nsCAutoString10nsACString
ld: 0711-317 ERROR: Undefined symbol: .nsCString::~nsCString()
ld: 0711-317 ERROR: Undefined symbol: .PR_LoadLibrary
ld: 0711-317 ERROR: Undefined symbol: .nsDebug::Warning(const char*,const char*,int)
ld: 0711-317 ERROR: Undefined symbol: .PR_FindFunctionSymbol
ld: 0711-317 ERROR: Undefined symbol: .nsHashtable::Get(nsHashKey*)
ld: 0711-317 ERROR: Undefined symbol: .NS_NewAtom(const char*)
ld: 0711-317 ERROR: Undefined symbol: .nsServiceManager::GetService(const
nsID&,const nsID&,nsISupports**,nsIShutdownListener*)
ld: 0711-317 ERROR: Undefined symbol: .nsCompressedCharMap::nsCompressedCharMap()
ld: 0711-317 ERROR: Undefined symbol: .nsCompressedCharMap::SetChars(unsigned
short*)
ld: 0711-317 ERROR: Undefined symbol: .nsCompressedCharMap::NewCCMap()
ld: 0711-317 ERROR: Undefined symbol: .NS_CheckThreadSafe
ld: 0711-317 ERROR: Undefined symbol: .nsTraceRefcnt::LogAddRef(void*,unsigned
int,const char*,unsigned int)
ld: 0711-317 ERROR: Undefined symbol: .nsTraceRefcnt::LogRelease(void*,unsigned
int,const char*)
ld: 0711-317 ERROR: Undefined symbol: .NS_CurrentThread
ld: 0711-317 ERROR: Undefined symbol: .FreeCCMap(unsigned short*&)
ld: 0711-317 ERROR: Undefined symbol: .nsCString::AppendInt(int,int)
ld: 0711-317 ERROR: Undefined symbol: __vft17nsSharableCString10nsACString
ld: 0711-317 ERROR: Undefined symbol: __vft24nsASingleFragmentCString10nsACString
ld: 0711-317 ERROR: Undefined symbol: __vft16nsQueryInterface15nsCOMPtr_helper
ld: 0711-317 ERROR: Undefined symbol: __vft10nsACString
ld: 0711-317 ERROR: Undefined symbol: .StringAllocator_char()
ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information.
gmake[5]: *** [libgfxft2.so] Error 8

I have a patch which resolves this error by adding some libraries to
EXTRA_DSO_LDOPTS in the Makefile.in. Once this patch is applied, I will turn on
freetype on the AIX tinderbox.

Comment 1

[Philip K. Warren]

Attachment: Adds needed libraries to EXTRA_DSO_LDOPTS

Need to link with MOZ_COMPONENT_LIBS and libgxgfx.

Comment 2

[Philip K. Warren]

Reassigning bug to me.

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 107059 [details] [diff] [review]
Adds needed libraries to EXTRA_DSO_LDOPTS

Order matters. That should be:
$(LIBS_DIR) \
-lgkgfx \
$(MOZ_COMPONENT_LIBS) \

Comment 4

[Philip K. Warren]

Attachment: Correct patch

Comment 5

[Philip K. Warren]

Checked in:

Checking in Makefile.in;
/cvsroot/mozilla/gfx/src/freetype/Makefile.in,v  <--  Makefile.in
new revision: 1.6; previous revision: 1.5
done

Comment 6

[Yuying Long]

Can someone who has AIX machine please verify this bug? thanks!

Comment 7

[Philip K. Warren]

The freetype library now builds correctly on AIX, but it was made into a static
library with the checkin for Bug 180473, so I think these changes are no longer
needed. Should this patch be backed out?