181586 - Ctrl+0 selects tenth tab instead of returning to 100% zoom

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[:deanis74]

1. Open ten tabs
2. Select any tab but the tenth tab
3. Ctrl+- to zoom out
4. Ctrl+0

Expected Results: zooms back to 100%

Actual Results: tenth tab is activated

Comment 1

[:deanis74]

Targetting to 0.6, as requested by Blake.

Comment 2

[:deanis74]

If the intended behavior is that Ctrl+0 restores the text zoom, then the problem
is in ctrlNumberTabSelection in browser.js.  The change to make would be:

  var index = event.charCode - 49;
  if (index == -1)
-   index = 9;
- if (index < 0 || index > 9)
+   index = 8;
+ if (index < 0 || index > 8)
    return;

Comment 3

[:deanis74]

Argh, that's not it at all.  This is probably more correct.  Merrily we spam along!

  var index = event.charCode - 49;
- if (index == -1)
-   index = 9;
- if (index < 0 || index > 9)
+ if (index < 0 || index > 8)
    return;

Comment 4

[:deanis74]

Attachment: patch

Yep, that fixes it.  This patch maintains Ctrl+1 through Ctrl+9 but removes
Ctrl+0 to select the tenth tab, leaving it strictly for restoring text zoom to
100%.

Comment 5

[:deanis74]

taking

Comment 6

[:deanis74]

checked in

Comment 7

[noririty]

v.