181602 - Convert accessible/ to use the newer pref APIs

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: The patch

Comment 2

[Aaron Leventhal]

Comment on attachment 107227 [details] [diff] [review]
The patch

r=aaronl

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in.

Comment 4

[Mikael Parknert]

some files using nsIPref again. Patch coming up

Comment 5

[Mikael Parknert]

Attachment: patch

who reviews for accessible/ ?

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Please don't reopen bugs which were fixed at one point.  This should have stayed
fixed, and a new bug opened.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 138630 [details] [diff] [review]
patch

>-  nsCOMPtr<nsIPref> prefService(do_GetService(kPrefCID));
>+  nsCOMPtr<nsIPrefBranch> prefService(do_GetService(NS_PREFSERVICE_CONTRACTID));

Don't lie.  nsIPref is a service, so it is legit to call the variable
|prefService|.	nsIPrefBranch is not a service, so it is bogus to store one in
a variable with service in the name.

Comment 8

[Mikael Parknert]

Sorry about the reopen. Should this be closed again and a new opened?

Comment 9

[Mikael Parknert]

Attachment: with caillons comments [checked in 20040123]

Comment 10

[Mikael Parknert]

Comment on attachment 139179 [details] [diff] [review]
with caillons comments [checked in 20040123]

r/sr/rs?

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 139179 [details] [diff] [review]
with caillons comments [checked in 20040123]

Yes, a new one should have been opened.

Comment 12

[Simon Paquet [:sipaq]]

Comment on attachment 139179 [details] [diff] [review]
with caillons comments [checked in 20040123]

Asking peterv for sr, since he already sr'ed the first patch two years ago.