181791 - [FIX]getElementsByTagNameNS(null, <whatever>) does not work

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Cesar Eduardo Barros]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021123
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021123

When you have a element with a null namespace, getElementsByTagNameNS(null,
tagname) should find it. This is not working. The workaround of
getElementsByTagName(tagname) works.

Reproducible: Always

Steps to Reproduce:
1.Open testcase
2.Click the button
It will show how many elements were found.
Actual Results:  
0 elements were found

Expected Results:  
Found the <data xmlns="">...</data> element (the alert should show 1)

Comment 1

[Cesar Eduardo Barros]

Attachment: Simple testcase

Comment 2

[Cesar Eduardo Barros]

Assigning to bzbarsky as requested by him on IRC

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Need to check for empty string

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

See bug 112062.

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

I think that what we really want to do is fix FindNamespaceID to work with the
empty string also, rather than do a special hack here.

Comment 6

[Boris Zbarsky [:bzbarsky]]

I considered that, but there may be other callers relying on the current
behavior... if there are not, I'm all for changing it.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

I think you should be fine.  There are two versions of FindNameSpaceID in the
file.  One is internal and is used only in the two places you changed.  The
other is on the interface and does different things.

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

lxr is your friend :)
http://lxr.mozilla.org/mozilla/search?string=findnamespaceid

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Fine, you win

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 107316 [details] [diff] [review]
Fine, you win

>@@ -455,26 +460,23 @@
>                                         PRInt32& aNameSpaceID)
> {
>   NS_ASSERTION(!gNameSpaceManagerWasShutDown,
>                "Namespace manager used past content module shutdown!!!");
> 
>   PRInt32 id = FindNameSpaceID(aURI);
>-
>+   

feel free to not do this change. I don't really care either way though.

>+    if (!uri)
>+      return NS_ERROR_OUT_OF_MEMORY;

Nit (since you didn't add this):
I prefer NS_ENSURE_TRUE(uri, NS_ERROR_OUT_OF_MEMORY), not a biggie though

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 107316 [details] [diff] [review]
Fine, you win

sr=jst, but please don't add spaces for indentation on empty lines :-)

Comment 12

[Boris Zbarsky [:bzbarsky]]

fixed.  I took the whitespace change out.