182099 - lock up on stylesheets tab double-clicking the twisty

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect, P2)

Description

[Hixie (not reading bugmail)]

Following the following steps causes Mozilla to lock up:

<Hixie> caillon: http://www.hixie.ch/tests/evil/mixed/cascade/acidlinkcascade.html
<Hixie> caillon: go to that, show the stylesheet list
<Hixie> caillon: then double click on the first twisty

<Hixie> caillon: i can't trigger the lockup with a data: uri @importing a data:
uri, so it's not a simple "twisties are broken" bug

Comment 1

[Alex Vincent [:WeirdAl]]

Eww.  Whatever it is, the bug is likely to be found via this file:
http://lxr.mozilla.org/seamonkey/source/extensions/inspector/resources/content/viewers/stylesheets/stylesheets.js

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: One-liner

So the problem was we were going around in an infinite loop in twisty code:
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/bindings/tree.xml#747


We never exited the while loop because in this case we have no parent, and are
expected to return -1, but were in fact returning 0 from our custom view's impl
of getParentIndex.  This fixes that.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 121779 [details] [diff] [review]
One-liner

sr=me but please document this in nsITreeView.idl (why do we write "interfaces"
that are so poorly documented as to be useless again?)

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 121779 [details] [diff] [review]
One-liner

Added the comment locally.  Will check in with this change.  Seeking 1.4b
approval for this small hang fix.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 121779 [details] [diff] [review]
One-liner

a=sspitzer

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in.