182161 - Remove confirm dialog from linux installer

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Jason Kersey]

The linux installer currently throws up a dialog at the end of an install, that
is not present in any other platform installers, and seems to be generally
useless.  It also blocks the full automation of the install, as even if you are
doing a scripted install you still have to attend to the install to clear the
dialog at the end of the install.  It really should just be removed, as it's
completely useless, and offers the user no additional information or choice. 
Brian found the dialog code, and said it should be easy to remove.

Comment 1

[Alexander Opitz]

Is this Dialog also shown, if you use the silent mode of the Linux installer?
Cause I think you haven't try to automate the GTK Install Prozess.

Comment 2

[Andrew Schultz]

Attachment: patch

yanks out confirmation dialog.

Comment 3

[Andrew Schultz]

Comment on attachment 140584 [details] [diff] [review]
patch

dveditz, can you review?
thanks!

Comment 4

[Andrew Schultz]

> It also blocks the full automation of the install,

mozilla-installer -ms  (silent mode)

Comment 5

[Daniel Veditz [:dveditz]]

The checks around the ShowCompleteDlg() call added in r1.25 should have checked
for MODE_AUTO (-ma) in addition to MODE_SILENT, but I agree it's pretty useless
anyway and can be removed.

Please also remove COMPLETED from strkeys in nsXIContext.cpp and from installer.ini

Comment 6

[Andrew Schultz]

Attachment: patch v2

also rips completion-related code from nsXIContext.cpp, installer.ini and
nsInstallerDlg.h

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 140644 [details] [diff] [review]
patch v2

r=dveditz (or sr=dveditz if  it's easier to get another r=)

Comment 8

[Andrew Schultz]

biesi: can you check this patch in?
thanks!

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 10

[benc]

V/fixed:
being seeing the changed behavior for quite a while.