182192 - Remove quotes (") from collected addresses

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Roger Perttu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826

It would be nice if double quotes in the from field is not imported in collected
addresses.

From: "First Last" <[e-mail]>
Ends up like this in the address book:
 First:   "First
 Last:    Last"
 Display: "First Last"

Makes it hard to search the address book

Reproducible: Always

Steps to Reproduce:



Expected Results:  
First:   First
Last:    Last
Display: First Last

I would assume this is a duplicate bug, but I couldn't find any

Comment 1

[Boris 'pi' Piwinger]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030117

I think, this is not only an enhancement, but also a bug. As you say, first and
last name do enclose the quotes which is certainly not correct. There might be a
reason to not remove the quotes completey, though.

I also cannot find a dupe.

Possibly, this here blocks bug 168204.

pi

Comment 2

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 3

[WD]

*** Bug 224097 has been marked as a duplicate of this bug. ***

Comment 4

[[e-mail]]

Attachment: Proposed patch

We just need to unquote the name before collecting it.

[ A pity someone couldn't spell collector ;-) ]

Comment 5

[David :Bienvenu]

Comment on attachment 138479 [details] [diff] [review]
Proposed patch

can you use an nsXPIDLCString for unquotedName? That would be slightly more
robust in terms of other changes introducing memory leaks.

Comment 6

[[e-mail]]

Attachment: Use nsXPIDLCString

Comment 7

[[e-mail]]

Comment on attachment 147661 [details] [diff] [review]
Use nsXPIDLCString

Sorry for the delay but I wasn't CC'd on the bug.

Is this patch small enough for r/sr?

Comment 8

[[e-mail]]

Comment on attachment 147661 [details] [diff] [review]
Use nsXPIDLCString

Whoops, helps to specify a requestee ;-)

Comment 9

[[e-mail]]

Fix checked in.

Comment 10

[Boris 'pi' Piwinger]

Since 1.7 will be a major release (long term), I suggest to take it there also.

pi

Comment 11

[Asa Dotzler [:asa]]

I don't think we'd block the release for this. blocking1.7-

Comment 12

[Boris 'pi' Piwinger]

Comment on attachment 147661 [details] [diff] [review]
Use nsXPIDLCString

We have a fix, this would be very useful (usability!) for a long term release
like 1.7.

pi

Comment 13

[Mike Kaply [:mkaply]]

Comment on attachment 147661 [details] [diff] [review]
Use nsXPIDLCString

a=mkaply

Comment 14

[Karen Huang]

Verified as fix on latest 1.7 branch 06-24 builds.
Changing keywords from fixed1.7 to verified1.7.
Leave this bug status "as is" until this bug be verified on trunk again...