182928 - Add Set Wallpaper dialog to customize settings and confirm

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Jeff Thieleke]

It quite easy to overshoot the "Save Image As" context menu item and accidently
select "Set As Wallpaper".  This isn't a major tragedy, but it is irritating and
it could potentially overwrite the user's desired wallpaper image file.

Since the typical user rarely uses the "Set As Wallpaper" feature, I suggest
that a confirmation dialog be added to setWallpaper() to help prevent accidental
usage.

Comment 1

[Jeff Thieleke]

Attachment: Add a confirmation dialog to setWallpaper()

Comment 2

[Sébastien Delahaye]

Updating summary (RFE is deprecated, enhancement only is enough).

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 107875 [details] [diff] [review]
Add a confirmation dialog to setWallpaper()

blake, can you take a look at this request and either resolve as wontfix or
review the attached patch? Thanks.

Comment 4

[Jesse Ruderman]

I agree that there should be a confirmation dialog for Set as Wallpaper.  The
lack of a confirmation dialog makes the Set as Wallpaper feature less useful to
me, because I keep accidentally blowing away my carefully chosen Phoenix
Wallpaper.bmp when trying to save porn images.

It would be nice if the dialog could contain thumbnails and buttons for possible
wallpaper positions (for example, tile, center, stretch, stretch proportionally,
and top-left).  But don't let that slow this bug from being fixed :)

Comment 5

[Michael Newton]

+wallpaperconfirmmsg=Do you want this image your new desktop wallpaper?

That could probably be worded a little better. "Would you like to use this image
as your desktop wallpaper?" or something otherwise gramatically correct.

Comment 6

[Paul Shuttle]

I'm not sure of the procedure here, but a patch has been waiting for review for
nearly a year now, and nothing has happened. I'm aware the patch may need
updating (codebase changes in Phx/FB since then may have rendered it
inoperative), but it would be nice to see something happen here.

Sorry if you're not supposed to "bump" bugs, but this seems like a fairly easy
and quick one to solve.

Comment 7

[Paul Shuttle]

Just thinking - wouldn't it be better to have the confirmation dialogue appear
for "Send Image" as opposed to/in addition to "Set as Wallpaper", since you're
more likely to accidently hit "Send Image" now (since it's right next to "Save
Image As")? I'm not sure if this was always the case, but i'm certainly hitting
that button a lot more than I used to, so I'm tempted to say the menu options
have been moved around at some point.

Or maybe my accuracy is getting worse.

Comment 8

[David Lynch]

Not really -- Set As Wallpaper one is a problem because it is, so to say, 
dataloss.  (Not to mention a rather unlikely feature to want to use... but 
that's neither here nor there.  I removed the menu item and haven't missed it, 
though.)  Accidentally clicking there changes the user's desktop with no quick 
way to return it to its prior setting.  What if the users' wallpaper was some 
other nifty picture they'd found randomly on the web and used Set As Wallpaper 
to make theirs, after all?  If they couldn't remember where it was, then they 
probably wouldn't be able to find the file on their computer.

Send Image, however, already has a confirm dialogue, as it were.  It opens an 
email message, which one may close without sending.  If Send Image / Send Link 
instead automatically sent an email to everyone in your address book *then* 
it'd need a confirmation.

Comment 9

[Paul Shuttle]

Some userChrome editing has resulted in both "Set As Wallpaper" and "Send Image"
being non-issues for me, and - since I agree with the points made about Send
Image not requiring a confirmation - ignore my previous point.

The Set Wallpaper patch still needs to be checked in though, if only to remain
consistent with IE and to prevent the data loss covered in Comment #8.

Comment 10

[Blake Ross]

Fix checked in. Thanks for the patch!

Comment 11

[Gervase Markham [:gerv]]

As mentioned above, the Right Thing To Do here (to turn the lesser-of-two-evils
confirmation popup into an actually useful feature) is to have a dialog allowing
you to specify wallpaper position, tiling etc. etc. This would give us a good
"better than IE" feature.

But, given that I'm not volunteering to write one, I'll just mention it and then
go away again...

Gerv

Comment 12

[David Tenser [:djst]]

(In reply to comment #11)
> As mentioned above, the Right Thing To Do here (to turn the lesser-of-two-evils
> confirmation popup into an actually useful feature) is to have a dialog allowing
> you to specify wallpaper position, tiling etc. etc.

Or maybe use a sub-menu instead, which would make the confirmation dialog
unnecessary (it's unlikely that you accidentally open a sub-menu and then click):

Set as Wallpaper > Centered
                   Tiled
                   Stretched

That would probably be less chrome than a dialog too.

Comment 13

[Blake Ross]

I'm working on the "better than IE" approach.

Comment 14

[Blake Ross]

Attachment: seamonkey build patch