183378 - user-agent / version line contains the wrong / incorrect version for 1.2.1 - reported to be 1.2

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Chris Ruvolo]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021203
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021203

I just installed 1.2.1 onto a RH 6.2 system.  User-Agent line reports version
1.2 even though I am fairly sure that the version actually running is 1.2.1.  I
have not done anything to try to spoof the User-Agent, and the only thing that
might be at issue in the .js files:

user_pref("browser.startup.homepage_override.mstone", "rv:1.2");


Reproducible: Always

Steps to Reproduce:
Help | About 
or
mozilla -version


Actual Results:  
Note version string is 1.2 instead of 1.2.1

Expected Results:  
Version string should read 1.2.1

This is not an official build.  I downloaded the rh8_xft .srpm and rebuilt it
with some minor modifications to the spec file (and only the spec file) under RH
6.2.

I am sure that I am not running 1.2 that I had installed previously:


> ps -auxc | grep moz | grep -v grep | head -1
cruvolo    447  2.7  5.9 38844 31320 pts/24  S    17:48   0:47 mozilla-bin

> ls -l /proc/447/exe 
lrwx------    1 cruvolo  users           0 Dec  3 18:17 /proc/447/exe ->
/usr/lib/mozilla-1.2.1/mozilla-bin*

> /usr/lib/mozilla-1.2.1/mozilla-bin -version
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021203, build 2002120316

> ls -l /usr/lib/mozilla-1.2.1/mozilla-bin 
-rwxr-xr-x    1 root     root       258012 Dec  3 16:48
/usr/lib/mozilla-1.2.1/mozilla-bin*

> ls -l /usr/lib/mozilla-1.2/mozilla-bin 
ls: /usr/lib/mozilla-1.2/mozilla-bin: No such file or directory




diff for the spec file is as follows (3 lines):

> diff -u mozilla-2002120215-MOZILLA_1_2_1_RELEASE.spec~
mozilla-2002120215-MOZILLA_1_2_1_RELEASE.spec
--- mozilla-2002120215-MOZILLA_1_2_1_RELEASE.spec~      Mon Dec  2 16:26:55 2002
+++ mozilla-2002120215-MOZILLA_1_2_1_RELEASE.spec       Tue Dec  3 16:22:23 2002
@@ -1,11 +1,11 @@
 %define _unpackaged_files_terminate_build 0
-%define toolkit_options --disable-freetype2 --enable-xft
+%define toolkit_options --disable-freetype2 --disable-xft
 %define builddir %{_builddir}/mozilla
 
 Name:        mozilla
 Summary:     Web browser and mail reader
 Version:     1.2.1
-Release:     0_rh8_xft
+Release:     0_rh62_csr
 Serial:      35
 Copyright:   MPL
 Source0:     mozilla-source-1.2.1-0_rh8_xft.tar.gz
@@ -187,7 +187,7 @@
 fi
 
 # build mozilla
-CC=gcc296 CXX=g++296 \
+CC=gcc CXX=g++ \
 BUILD_OFFICIAL=1 MOZILLA_OFFICIAL=1 \
        ./configure --prefix=%{_prefix} --enable-optimize \
        --disable-debug \



Let me know if there is other info I can provide that might be useful.

-Chris

Comment 1

[Chris Ruvolo]

I tried changing the .js file to read:

user_pref("browser.startup.homepage_override.mstone", "rv:1.2.foo");

and it doesn't effect the user-agent in help|about.  This is not a factor.

Comment 2

[Boris Zbarsky [:bzbarsky]]

chris, I've seen this a few times now, always about rpm builds...

Comment 3

[Christopher Blizzard (:blizzard)]

leaf, I think the tag is busted:

[blizzard@shona init]$ cvs status all.js 
===================================================================
File: all.js            Status: Up-to-date

   Working revision:    3.427.2.2
   Repository revision: 3.427.2.2      
/cvsroot/mozilla/modules/libpref/src/init/all.js,v
   Sticky Tag:          MOZILLA_1_2_1_RELEASE (revision: 3.427.2.2)
   Sticky Date:         (none)
   Sticky Options:      (none)

[blizzard@shona init]$ grep 1.2 all.js 
pref("general.useragent.misc", "rv:1.2");
//   pref("network.security.ports.banned", "1,2,3,4,5");


and:

[blizzard@shona init]$ cvs status all.js 
===================================================================
File: all.js            Status: Up-to-date

   Working revision:    3.427.2.3
   Repository revision: 3.427.2.3      
/cvsroot/mozilla/modules/libpref/src/init/all.js,v
   Sticky Tag:          MOZILLA_1_2_BRANCH (branch: 3.427.2)
   Sticky Date:         (none)
   Sticky Options:      (none)

[blizzard@shona init]$ grep 1.2 all.js 
pref("general.useragent.misc", "rv:1.2.1");
//   pref("network.security.ports.banned", "1,2,3,4,5");

Comment 4

[R.K.Aa.]

*** Bug 183488 has been marked as a duplicate of this bug. ***

Comment 5

[Daniel (Leaf) Nunes]

I don't know how this happened. I ran the tag on my local tree, which hasn't
changed since then, and the revision there is correct.

I'll run a diff and fix the old files that made it onto the RELEASE tag.

Comment 6

[Chris Ruvolo]

I can confirm that in my installation
/usr/lib/mozilla-1.2.1/defaults/pref/all.js has the following line:

  pref("general.useragent.misc", "rv:1.2");

and if I change it to read:

  pref("general.useragent.misc", "rv:1.2.1");

Then mozilla reports 1.2.1.

Comment 7

[Daniel (Leaf) Nunes]

tag is fixed, re-pushing sourcefiles.

Comment 8

[Chris Ruvolo]

Re: comment #7

Were there any files involved besides the all.js file?

Comment 9

[Andrew Schultz]

==> leaf

Comment 10

[Joe Pranevich]

I can confirm that this problem also exists with the 7.x SRPMS built on
Compaq/Redhat 7.2 for Alpha. Adjusting the "Hardware" field accordingly, but I
suspect that this bug is just waiting to be closed...

Comment 11

[Daniel (Leaf) Nunes]

yes, tag is fixed, new source tarballs have been pushed.

Comment 12

[R.K.Aa.]

*** Bug 185764 has been marked as a duplicate of this bug. ***