183415 - PAC: Apparent typo

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Nathan Kurz]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4

I can't tell if this is a bug, but it sure looks suspicious.  I was reading
through to see how proxy autoconfiguration is handled, and came across this code
in nsProxyAutoConfig.js:

222         if (!iid.equals(nsIProxyAutoConfig) &&
223             !!iid.equals(Components.interfaces.nsIStreamListener) &&
224             !iid.equals(Components.interfaces.nsISupports)) {

Can this double negative in line 223 be intentional?  This line came in as a
patch for bug #53080, and was like this even in the earliest versions of the
patch.  Could someone knowledgeable take a glance at it?  

Apologies if I'm not seeing the obvious.




Reproducible: Always

Steps to Reproduce:

Comment 1

[benc]

-> whitebox, now that I think about it...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yeah, that looks totally wrong.  That object implements nsIStreamListener...

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: the obvious patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 142567 [details] [diff] [review]
the obvious patch

sr=bzbarsky

Comment 5

[Darin Fisher]

Comment on attachment 142567 [details] [diff] [review]
the obvious patch

hmm.. seems like it should also support nsIRequestObserver.

want to add a line for that?

r=darin

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in with added nsIRequestObserver