183569 - every time I type a char in a message compose body, I see "no update for command: cmd_smiley" on the console

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[(not reading, please use [e-mail] instead)]

every time I type a char in a message compose body, I see:

"no update for command: cmd_smiley" on the console

Comment 1

[Charles Manske]

I know about this Composer problem.

Comment 2

[Stephen Walker]

*** Bug 189200 has been marked as a duplicate of this bug. ***

Comment 3

[Stephen Walker]

Attachment: Add a cmd_smiley case

Comment 4

[[e-mail]]

The CVS blame for this diff for the fix for this points at bug 180303 but that
bug doesn't have a relevant patch... I guess it got checked in by mistake :-)

Comment 5

[Stephen Walker]

Reopening,
http://lxr.mozilla.org/mozilla/source/editor/ui/composer/content/ComposerCommands.js#304
will still cause the console message to be dump'ed.

Comment 6

[[e-mail]]

But nobody should be calling goUpdateCommandState('cmd_smiley') ...

Comment 7

[[e-mail]]

Comment on attachment 138738 [details] [diff] [review]
Add a cmd_smiley case

OK, so after you insert a smiley Composer now thinks that smileys have state
(which they don't, it's just a hack) but you should not poke the state...

Comment 8

[Stephen Walker]

Attachment: Add a cmd_smiley case (in the right place)

goUpdateCommandState('cmd_smiley') is still called

321	  if (commandNode.hasAttribute("state"))
322	    goUpdateCommandState(commandID);

because doStatefulCommand() adds the state attrib to the command.

412 function doStatefulCommand(commandID, newState)
413 {
414   var commandNode = document.getElementById(commandID);
415   if (commandNode)
416	  commandNode.setAttribute("state", newState);

But doStatefulCommand() already calls pokeMultiStateUI(), so the case should be
moved down a few lines.

Comment 9

[[e-mail]]

Comment on attachment 138983 [details] [diff] [review]
Add a cmd_smiley case (in the right place)

Looks good to me, but I'm rebuilding right now...

Comment 10

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 138983 [details] [diff] [review]
Add a cmd_smiley case (in the right place)

r=[e-mail]

Comment 11

[[e-mail]]

Fix checked in.