183856 - Download Folder not updated during same session.

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Stephane Moureau]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021204 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021204 Chimera/0.6+

If you change the Download Folder in the System Preferences during a session,
the path is (only?) updated after restarting Chimera.

Reproducible: Always

Steps to Reproduce:

Actual Results:  
Same path kept during all the session.

Expected Results:  
Update the download path if it's changed.

Comment 1

[Chris Petersen]

Yep, I saw this earlier today with the 2002-12-05-04 NB. Uses the old path until
quit and relaunch Chimera. When downloading a file, the new path now appears (in
the DL window) specified by user's system preferences.

Comment 2

[Steve Dagley]

How often do you change your download folder location?  I'll give this bug a day
to see if anyone can give me a good reason to not mark it WONTFIX.  And this
isn't Chimera specific, all Mozilla based browsers behave this way.

Comment 3

[Stephane Moureau]

How often ? At least once when a new user will install the program, change the
folder as it will be explained in the doc and then realize that it does not work.
It will only work after relaunching Chimera.
For me, I don't care, I just hightlight strange behaviors.

Comment 4

[Steve Dagley]

That's a good reason :-)  Especially now that Chimera has UI to display the DL
folder and a button to get you to the Internet prefs pane of System Preferences
to change it.  I was too used to the lack of DL folder info in Mozilla to
appreciate this was a problem.  Patch coming.

Comment 5

[Steve Dagley]

Attachment: Don't cache DL folder on Mac

Comment 6

[Steve Dagley]

Comment on attachment 108497 [details] [diff] [review]
Don't cache DL folder on Mac

Setting review and approval request flags since this is also needed on trunk.

Comment 7

[Steve Dagley]

Checked in for Chimera but won't appear until after the 12/06/2002 build

Comment 8

[Conrad Carlen (not reading bugmail)]

Comment on attachment 108497 [details] [diff] [review]
Don't cache DL folder on Mac

r=ccarlen

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 108497 [details] [diff] [review]
Don't cache DL folder on Mac

This can wait until the trunk opens for 1.3b (real soon now)

Comment 10

[Simon Fraser [no longer active]]

Comment on attachment 108497 [details] [diff] [review]
Don't cache DL folder on Mac

I think we need to start listening for IC changes (there's a serial number you
can keep an eye on). We have to update proxy settings when the user changes
machine lcoation, for example. What we should do is have some central place
where we mirror IC prefs into mozilla prefs, and update it at this time.

Meanwhile, this patch seems OK.

Comment 11

[Stephane Moureau]

Just in case, what happens if a huge/slow download is running and that the path
is changed ? No need to answer me :)

Comment 12

[Steve Dagley]

To answer Simon's comment: Yes, I first thought of checking ICGetSeed() but I
talked to Conrad and the way the directory service caches the folders doesn't
give is a chance to do that.  And note that to avoid a nasty dependency problem
the directory service code doesn't use the IC service, it calls IC directly.

To asnwer Stephane: The new DL folder won't be recognized until the next
download :-)

Comment 13

[Conrad Carlen (not reading bugmail)]

> What we should do is have some central place
where we mirror IC prefs into mozilla prefs

For this case alone, simply not caching the value is fine. If there's other need
for monitoring IC pref changes (done outside xpcom), that code could call
nsIProperties::Undefine(NS_MAC_DEFAULT_DOWNLOAD_DIR) on
@mozilla.org/file/directory_service;1

Comment 14

[Steve Dagley]

Checked in on the Mozilla trunk so now marking fixed.

To verify:
1) Set the DL folder in the Web tab of the Internet prefs pane of System
Preferences.app.
2) Launch Mozilla and click on a DL link such as a .sit or .pdf file that will
be handed off to a helper app.
3) Note that the file downloaded goes to the folder you specified in Step #2.
4) While Mozilla is running repeat step #1 but pick a different download location.
5) Click on another DL link such as a .sit or .pdf file that will be handed off
to a helper app.
6) Observe that the file downloaded in step #5 goes to the newly selected
download folder.