184108 - Save As <<filename>> without <<.html>> extention result is a html file <<filename>> and a directory <<_files>>

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Frank Roelants]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130

When I saved a complete webpage with mozilla 1.11 using the "Save as" menuitem
and I entered only the name of the page without .html extention it resulted in a
html file filename.html and a directory filename_files . This version does that
any more. I need to enter the complete name. Saving two pages in one directory
results in problems, the second time does the directory _files already exists.

Reproducible: Always

Steps to Reproduce:
1.menu: file - Save As
2.enter <<filename>> without .html


Actual Results:  
a html file filename
a directory _files

Expected Results:  
a html file filename.html or filename
a directory filename_files

I'm using Suse8.0 and mozilla is installed in /opt/mozilla

Comment 1

[Andrew Schultz]

==> File Handling

Comment 2

[Boris Zbarsky [:bzbarsky]]

This is a webbrowserpersist bug.

Comment 3

[Adam Lock]

I don't have Suse but I can verify with RH on a recent build. From the looks of
it, it is due to the file selector not putting the proper file extension on the
document name when it tells it to save. The perist object doesn't append an
extension for itself, expecting the caller to do that.

Reassigning to module owner.

Comment 4

[timeless]

Attachment: fix

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 124053 [details] [diff] [review]
fix

r+ because this code is broken; but it doesn't fix this bug.

I will attach a patch that does fix it.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: additional fix

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 124545 [details] [diff] [review]
additional fix

bz - this is a really small patch, would be great if you could find the time to
sr it

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 124545 [details] [diff] [review]
additional fix

sr=me, but this looks identical to timeless' patch, so if you were going to
make other changes, you forgot to...

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

bz: yeah, it is identical, but in a different file :)

Comment 10

[Boris Zbarsky [:bzbarsky]]

Ah.  Yeah, we need both changed... friggin' code duplication.  :(

Comment 11

[timeless]

checked in

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 216818 has been marked as a duplicate of this bug. ***