184208 - When downloading, the download sidebar opens in all windows, including popups windows

Status: RESOLVED INVALID

(Toolkit :: Downloads API, defect)

Description

[http://tinymailto.com/oliversl]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5

When you setup Phoenix downloads to:
[ ] Display a progress dialog
[x] Open download sidebar
and you start downloading a file, the downloads sidebar appears in all open
windows, including the popups windows.


Reproducible: Always

Steps to Reproduce:
1. open 2 windows and a popup
2. start downloading a file

Actual Results:  
The download sidebar is displayed in all windows

Expected Results:  
The download sidebar should be displayed only in the window where you clicked to
download the file.

If you started a download from a popup window, don't know what should happend.

Comment 1

[Jeremy M. Dolan]

Linux 0.5 too. Confirming.

Comment 2

[Guenter Huerkamp]

The same result with bookmark-sidebar.
When you start phoenix with bookmark open. When a popup window starts the
bookmark-sidebar is displayed in all popup-windows.

Comment 3

[Duncan Kimpton]

Yep I see this too - with the bookmarks.

Very rarely does one actually want the sidebar to appear on popup windows - 
perhaps it should be optional like the status bar?

(Using 0.5 on Win 2K)

Comment 4

[Duncan Kimpton]

Using: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20030103 Phoenix/0.5

This is probably my number one gripe with Phoenix now.

Comment 5

[Asa Dotzler [:asa]]

Duncan, comments like "This is probably my number one gripe with Phoenix now."
are not only useless, they are counterproductive and waste the time of
developers and QA

Comment 6

[Matthew Good]

It seems that the sidebar should be disabled in popup windows when the toolbar
is.  Example JavaScript: window.open("http://url, "name", "toolbar=0");

Setting "toolbar=0" should disable the display of both the toolbar and the
sidebar in the window.  Most popups set "menubar=0" and "location=0" as well, so
some combination of these 3 setting could be used to determine whether to
display the sidebar, but I think just using the toolbar setting would be sufficient.

Comment 7

[Erik]

*** Bug 209402 has been marked as a duplicate of this bug. ***

Comment 8

[Bill Mason]

*** Bug 214307 has been marked as a duplicate of this bug. ***

Comment 9

[Bill Mason]

Tweaking summary to restate the issue since the old summary just refer to
download issues.

->General since this clearly not just a download/download sidebar issue.

Comment 10

[http://tinymailto.com/oliversl]

Comment #9
Please don't generalize a bug. Also, your new summary was hard to understand.
Thanks.

Comment 11

[Pham]

*** Bug 217533 has been marked as a duplicate of this bug. ***

Comment 12

[http://tinymailto.com/oliversl]

Please don't change the summary. And if you do, please post an explanation why.

Comment 13

[Mike Connor [:mconnor]]

no longer valid with the new download manager

Comment 14

[Jeremy Jongsma]

This is marked invalid because of the new download manager; has the bookmark
sidebar case (see #2) been fixed as well?

Comment 15

[Steffen Wilberg]

The download sidebar that has been removed, so there's no issue with that
anymore. But I haven't seen a bookmarks or history sidebar on a popup lately.

If anybody still sees that, I'd suggest to file a new bug and provide a testcase
or URL where it can be reproduced.

Comment 16

[Jeremy Jongsma]

Yeah, I just tested on a recent nightly... there's still an issue there.  The
bookmarks toolbar doesn't actually show up, but there is a weird spacer (approx.
5px wide) that shows up on the left side.  When you hit CTL-B (to disable
bookmarks sidebar), the spacer disappears.

I'll check around and open a new bug if it hasn't been reported.