184228 - Spelling error in irc.js: "function net_conenct()".

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Justin Turner Arthur]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021115
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021115

This doesn't seem to dramatically affect anything.The spelling error is right here:
     CIRCNetwork.prototype.connect =
     function net_conenct()
     {...}
I'd imagine that "conenct" should be "connect ".

Reproducible: Always

Steps to Reproduce:

Comment 1

[Olivier Cahagne]

not sure about that because there's already a net_connect() function:
http://lxr.mozilla.org/seamonkey/source/extensions/irc/js/lib/irc.js#241
In both cases, they're never used anywhere else anyway...

Comment 2

[Samuel Sieb]

There are a number of these spelling and copy/paste errors.
If anyone wants to hunt them down, please do.  :-)

Comment 3

[Andreas Kunz]

Well, they _are_ used, they are only not referenced by their name, but invoked
by a network object's connect() function.
E.g. the misspelled one is invoked from 
http://lxr.mozilla.org/seamonkey/source/extensions/irc/xul/content/static.js#2257

That is the reason why still everything works as expected and renaming generally
is not a problem at all.

However, I don't know enough about JavaScript to decide if correcting the name
will cause an error because there is already a function with this name, but with
different parameter count. Is overloading possible?

Comment 4

[Andreas Kunz]

Attachment: patch

Renames 'net_conenct' to 'net_connect' and the existing 'net_connect' to
'net_onconnect' (see diff for why).
This avoids confusion and problems with several functions having the same name.


lxr says that 'net_onconnect' is not used in the tree.

Comment 5

[Andreas Kunz]

Comment on attachment 121559 [details] [diff] [review]
patch

Requesting review from rginda.
I tested it and it ran properly and this is what I expected because the names
of the functions are never called. But you know JS better than me...

Comment 6

[Samuel Sieb]

If you don't mind, could you look through the files?  There are several more of
these errors.

Comment 7

[Andreas Kunz]

Samuel, you mean like all chatzilla JavaScript files?
Ummm...
:-)

It's not like one can do an automatic spellcheck on JS files...
I'll offer this one for starters. Maybe I'll read a bit in this file (irc.js),
but...

Comment 8

[Robert Ginda]

Comment on attachment 121559 [details] [diff] [review]
patch

I'll include this in the next xpi

Comment 9

[Robert Ginda]

marking fixed, 0.8.34 checked in.