184511 - need support for AIX 5.1 in NSPR 4.1.3

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Ian McGreer]

See bug 166412 for the corresponding bug for the tip.  We will need similar
changes for the obsoleted build system used in NSPR 4.1.

Comment 1

[Wan-Teh Chang]

Attachment: Patch for the NSPRPUB_RELEASE_4_1_BRANCH

The changes for mozilla/nsprpub/configure (which is
generated from mozilla/nsprpub/configure.in) are
omitted for brevity.

Comment 2

[Wan-Teh Chang]

Comment on attachment 108784 [details] [diff] [review]
Patch for the NSPRPUB_RELEASE_4_1_BRANCH

Note that
    ifeq (4.3,$(firstword $(sort 4.3 $(OS_RELEASE))))
is a GNU make idiom for
    if $(OS_RELEASE) >= 4.3

GNU make does not have any comparison operators
(greater than, less than, etc.), so we have to resort
to this hack.

Comment 3

[Ian McGreer]

I tested this patch on tiger (AIX 5.1) with 32-bit & 64-bit DBG/OBJ, everything
built OK.

Comment 4

[Wan-Teh Chang]

Ian, I'd like you to review this patch too, if possible.
Then, you can check it into the NSPRPUB_RELEASE_4_1_BRANCH
and mark this bug fixed.  Remember to log in on a Red Hat
Linux 7.1 machine and run "autoconf" in mozilla/nsprpub
to generate a new mozilla/nsprpub/configure.  If you don't
have access to a Red Hat Linux 7.1 machine, I can do that
for you.

This patch can be summarized in two changes.
1. Rename the AIX4_3 macro to AIX4_3_PLUS, which means the
OS version of the build machine is AIX 4.3 or higher.
2. In AIX.mk, if "4.3" satisfies an if test, "5.1" should
also satisfy the test.
These two changes make AIX 5.1 appear the same as AIX 4.3
to NSPR.

Comment 5

[Ian McGreer]

Comment on attachment 108784 [details] [diff] [review]
Patch for the NSPRPUB_RELEASE_4_1_BRANCH


As mentioned above, I have tested the patch.

Comment 6

[Wan-Teh Chang]

Patch checked into the NSPRPUB_RELEASE_4_1_BRANCH.