18477 - [IMG] max-height problem on image with display block and height auto

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  The image with class eleven in the above page is displayed with a
height of 600px, when it should be its natural size.

The problem is that when an image with display: block is between its max-height
and min-height, so neither property should do anything, it's getting its
max-height as its height.

STEPS TO REPRODUCE:
 * load attached testcase

ACTUAL RESULTS:
 * the image is 800px tall

EXPECTED RESULTS:
 * the image should be about 300px tall

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-11-09-08-M11

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase described in bug

Comment 2

[leger]

Updating to default Layout Assignee...kipp no longer with us :-(

Comment 3

[troy]

Why are you re-reassing layout bugs? Do NOT touch layout bugs.

The bugs are assigned to Kipp so they can stay neatly organized until we have a
new owner for the block/inline code.

Comment 4

[buster]

mass moving all Kipp's pre-beta bugs to M15.  Nisheeth and I will
prioritize these and selectively move high-priority bugs into M13 and M14.

Comment 5

[buster]

mine! mine mine mine!  all mine!  whoo-hoo!

Comment 6

[rickg]

moving all buster m15 bugs to m16.

Comment 7

[buster]

important to fix, but no owner currently

Comment 8

[buster]

redistributing bugs across future milestones, sorry for the spam

Comment 9

[buster]

This bug has been marked "future" because the original netscape engineer working 
on this is over-burdened. If you feel this is an error, that you or another 
known resource will be working on this bug,or if it blocks your work in some way 
-- please attach your concern to the bug for reconsideration. 

Comment 10

[Hixie (not reading bugmail)]

Attachment: Testcase which gets around bug in our strict DTD handling

Comment 11

[Hixie (not reading bugmail)]

It appears that this now works. However, we should test it again once the
height:% bug is fixed. Also, I tested it on Win2K, David originally reported
the bug on Linux.

Comment 12

[Hixie (not reading bugmail)]

(actually, just for the record, the testcase I attached did not get around a bug
in our strict DTD, it fixed a bug in the original testcase.)

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Percentage widths on images are completely broken right now.  Don't mark this
WORKSFORME until that is fixed...

Comment 14

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 15

[Hixie (not reading bugmail)]

There is still a bug here. I shall attach a testcase. It seems to only occur when 
the 'height' property is set to 'auto'.

Comment 16

[Hixie (not reading bugmail)]

Attachment: Self explanatory testcase

Comment 17

[rubydoo123]

odd: the testcase that Ian most recently added renders identically in todays 
build and in IE6.

Setting to P:2, Normal, mozilla 1.0

Comment 18

[jag (Peter Annema)]

Nothing odd about it, that would just imply IE6 is broken too ;-)

Comment 19

[Marc Attinasi]

So, will this bug magically fix itself in a couple of months, when it is two
years old  :) That would be cool, heh heh heh.

Comment 20

[jag (Peter Annema)]

Does that often happen to your bugs? If so, remind me to assign some to you just
before they turn 2 years old ;-)

Comment 21

[Peter Trudelle]

Could we get a fix for this before the end of mozilla098?  It blocks
implementation of a P2 feature on our PRD, part of a theme for MachV.

Comment 22

[jag (Peter Annema)]

Marc, is there any way you can get some time allocated for fixing this? Being
able to use this would suck less than a javascript based solution for automatic
image sizing (see my last comment in bug 73322).

Comment 23

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So pavlov broke min-height and max-height even more than it was broken when Ian
reopened the bug.  But I have a fix...

Comment 24

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 25

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking

Comment 26

[Stuart Parmenter]

Comment on attachment 60906 [details] [diff] [review]
patch

r=pavlov

Comment 27

[Marc Attinasi]

Comment on attachment 60906 [details] [diff] [review]
patch

sr=attinasi

Comment 28

[Cathleen]

dbaron landed the fix on 12/10/2001 19:21

Comment 29

[jag (Peter Annema)]

Hixie, in attachment 50145 [details] you say that "this should be after the image, not
under it". Is that correct, and if so, is that this bug or another one?

Comment 30

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See also bug 234686 for further refinements.