184801 - home button tooltip not updated when changing home page in preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Marc Boullet]

Patch following

Comment 1

[Marc Boullet]

Attachment: patch

this patch updates the home button tooltip when the preferences window is
exited.

Comment 2

[Jesse Ruderman]

You also need to update it if someone sets their home page by dragging a link to
the home button and clicks "Set Home Page" in the resulting dialog.

Comment 3

[Marc Boullet]

Jesse,
the case you mentionned works correctly.

Comment 4

[Bill Mason]

*** Bug 206095 has been marked as a duplicate of this bug. ***

Comment 5

[Blake Ross]

Fixed.

Comment 6

[noririty]

Still doesn't work well w/2003070608

Comment 7

[Blake Ross]

I guess you were referring to the fact that other windows' tooltips didn't
update with this patch. I've checked in a better fix, try again.

Comment 8

[noririty]

I think the bug is still there.
These are simple steps to reproduce.
1. Start Mozilla Firebird with a new profile.
2. Customize toolbar to show home icon (home button).
3. Click Bookmark toolbar folder item.
5. Open [Tools]-[Options...]-[General]
5. Click 'Use Current Page' and Press [OK] to close dialog.
6. Point 'Home' Icon.
*. result -> tooltip doesn't change.

when I choose 'Use Bookmark...' or 'Use Blank Page'
tooltip still doesn't change until restart browser.

Comment 9

[noririty]

Attachment: proposed patch

Comment 10

[noririty]

Comment on attachment 127360 [details] [diff] [review]
proposed patch

Blake, could you take a look at this?

Your fix works great when I manually input the homepage URI.
But when I select it by button:
ex) 'Use Current Page', 'Use Bookmark...' or 'Use Blank Page'
tooltip persists and doesn't change. Please see comment#8 for detail.

This is a proposed patch to solve this problem.

Comment 11

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

This patch is wrong. I've checked in a better one. (using a pref observer,
rather than relying on there being an open browser window, which is a bad
assumption, especially on MacOSX)

Comment 13

[Bill Mason]

v

Comment 14

[Andreas Kunz]

Comment on attachment 127360 [details] [diff] [review]
proposed patch

Review request obsolete.

Comment 15

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change