185033 - Drag and drop of text broken.

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Jason Bassford]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021212

With 2002121204 under XP I am unable to highlight text on a Web site and drag
and drop it anywhere.

Note, however, that drag and drop of text still works from within text boxes -
just not text displayed outside of text boxes.

(Unless I'm losing my mind, this was something that could be done - it wasn't
limited to text boxes in the past.  If I *AM* losing my mind, then this can be
turned into an enhancement request.)

I couldn't find a dupe of this after a quick Bugzilla search, but might have
just missed it.

Reproducible: Always

Steps to Reproduce:
1. Highlight text on any Web page that is not contained within a text box.
2. Drag and drop it into the Location bar, tab bar, or an input box.


Actual Results:  
Nothing happens.  (It is neither dragged nor dropped.)

Expected Results:  
The text should have been pasted to the destination upon mouse button release.

Comment 1

[Jason Bassford]

*** Bug 185036 has been marked as a duplicate of this bug. ***

Comment 2

[kinmoz]

Data point: My debug build from 8am on 12/10/02 works fine, but my debug build
from 9am on 12/11/02 shows the bug.

Comment 3

[kinmoz]

This change to nsDOMEvent::GetView() for bug 183999 seems to have broken things.
That is, the CallQueryInterface() fails because nsWebShell doesn't implement
nsIDOMAbstractView so a Drag is never started:

@@ -483,14 +484,10 @@
     rv = mPresContext->GetContainer(getter_AddRefs(container));
     NS_ENSURE_TRUE(NS_SUCCEEDED(rv) && container, rv);
     
-    nsCOMPtr<nsIInterfaceRequestor> ifrq(do_QueryInterface(container));
-    NS_ENSURE_TRUE(ifrq, NS_OK);
-    
-    nsCOMPtr<nsIDOMWindowInternal> window;
-    ifrq->GetInterface(NS_GET_IID(nsIDOMWindowInternal), getter_AddRefs(window));
+    nsCOMPtr<nsIDOMWindowInternal> window = do_GetInterface(container);
     NS_ENSURE_TRUE(window, NS_OK);
-    
-    window->QueryInterface(NS_GET_IID(nsIDOMAbstractView), (void **)aView);
+
+    CallQueryInterface(container, aView);
   }
 
   return rv;

Comment 4

[kinmoz]

FYI, I did verify that reverting that  portion of the patch back to what it was
gets things working again.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Oh, yikes.  Yeah, that should be:

CallQueryInterface(window, aView);

Comment 6

[Peter Van der Beken [:peterv]]

I corrected the obvious error. I'll see if that fixes it.

Comment 7

[Peter Van der Beken [:peterv]]

Fixed. Sorry.

Comment 8

[Jason Bassford]

Verifying resolution of all bugs I've reported.

(Although drag & drop of text is broken again, it is not for the same reason, so
I will not reopen this one.)