185251 - Trunk M140B crash using spell checker [@ XPCCallContext::GetRetValPtr] [@ nsTextServicesDocument::FirstBlock] [@ spellchk.dll | SPELLCHK.DLL] [@ UTF8InputStream::Read]

Status: VERIFIED INVALID

(Core :: DOM: Editor, defect, P3)

Description

[Jay Patel [:jay]]

Not sure if this a xpconnect problem or an editor issue, but there have been a
spike in crashes with this stack signature for 3 days starting on 12/10.  It's
happening on all flavors of windows and almost all the comments mention trying
to run the spell checker.  Here is the latest from Talkback:

XPCCallContext::GetRetValPtr   21 
BBID range: 14984025 - 15040547
Min/Max Seconds since last crash: 14 - 15200
Min/Max Runtime: 43 - 16994
Crash data range: 2002-12-11 to 2002-12-12
Build ID range: 2002121008 to 2002121204
Keyword List : crash(6), mail(4), 
Stack Trace: 

	 XPCCallContext::GetRetValPtr
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpccallcontext.cpp  line 439]
	 nsTextServicesDocument::GetCurrentTextBlock
[c:/builds/seamonkey/mozilla/editor/txtsvc/src/nsTextServicesDocument.cpp  line 424]
	 spellchk.dll + 0x1c1a (0x04c91c1a)
	 spellchk.dll + 0x1356 (0x04c91356)
	 nsEditorSpellCheck::GetNextMisspelledWord
[c:/builds/seamonkey/mozilla/editor/composer/src/nsEditorSpellCheck.cpp  line 168]
	 XPTC_InvokeByIndex
[c:/builds/seamonkey/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp 
line 106]
	 XPCWrappedNative::CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp  line 2018]
	 XPC_WN_CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp 
line 1293]
	 js_Invoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 841]
	 js_Interpret	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 2804]
	 js_Invoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 857]
	 js_InternalInvoke	[c:/builds/seamonkey/mozilla/js/src/jsinterp.c  line 932]
	 JS_CallFunctionValue	[c:/builds/seamonkey/mozilla/js/src/jsapi.c  line 3433]
	 nsJSContext::CallEventHandler
[c:/builds/seamonkey/mozilla/dom/src/base/nsJSEnvironment.cpp  line 1044]
	 nsJSEventListener::HandleEvent
[c:/builds/seamonkey/mozilla/dom/src/events/nsJSEventListener.cpp  line 184]
	 nsEventListenerManager::HandleEventSubType
[c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp  line
1218]
	 nsEventListenerManager::HandleEvent
[c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp  line
1902]
	 GlobalWindowImpl::HandleDOMEvent
[c:/builds/seamonkey/mozilla/dom/src/base/nsGlobalWindow.cpp  line 776]
	 DocumentViewerImpl::LoadComplete
[c:/builds/seamonkey/mozilla/content/base/src/nsDocumentViewer.cpp  line 968]
	 nsDocShell::EndPageLoad
[c:/builds/seamonkey/mozilla/docshell/base/nsDocShell.cpp  line 4242]
	 nsWebShell::EndPageLoad
[c:/builds/seamonkey/mozilla/docshell/base/nsWebShell.cpp  line 777]
	 nsDocShell::OnStateChange
[c:/builds/seamonkey/mozilla/docshell/base/nsDocShell.cpp  line 4176]
	 nsDocLoaderImpl::FireOnStateChange
[c:/builds/seamonkey/mozilla/uriloader/base/nsDocLoader.cpp  line 1215]
	 nsDocLoaderImpl::doStopDocumentLoad
[c:/builds/seamonkey/mozilla/uriloader/base/nsDocLoader.cpp  line 869]
	 nsDocLoaderImpl::DocLoaderIsEmpty
[c:/builds/seamonkey/mozilla/uriloader/base/nsDocLoader.cpp  line 767]
	 nsDocLoaderImpl::OnStopRequest
[c:/builds/seamonkey/mozilla/uriloader/base/nsDocLoader.cpp  line 697]
	 nsLoadGroup::RemoveRequest
[c:/builds/seamonkey/mozilla/netwerk/base/src/nsLoadGroup.cpp  line 703]
	 nsCachedChromeChannel::HandleStopLoadEvent
[c:/builds/seamonkey/mozilla/rdf/chrome/src/nsChromeProtocolHandler.cpp  line 480]
	 PL_HandleEvent	[c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c  line 645]
	 PL_ProcessPendingEvents	[c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c 
line 578]
	 _md_EventReceiverProc	[c:/builds/seamonkey/mozilla/xpcom/threads/plevent.c 
line 1336]
 
 	Source File :
c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpccallcontext.cpp line : 439
     (15023233)	Comments: opened browser  opened mail  opened a draft  invoked
spellchecker
     (15023101)	Comments: opened draft & clicked on spellchecker icon
     (15018509)	Comments: Spellchecker again I think. I will reload and try the
latest spellchecker. problem was it wasn't working yesterday
     (15017403)	Comments: generating an email - just hit send. I have Netscape's
spellchecker in which does crash first time after a reload - I have just loaded
the new Mozilla overnight and this is the first mail I have sent using the new load
     (14994837)	URL: http://altavista.com
     (14994837)	Comments: crashed while running spellchecker 
     (14989591)	Comments: Crashed after hitting send.  Only occured after
installing MozSpell_1.2f_w32.xpi spell checker.
     (14987695)	Comments: Crashes whenever I send an email
     (14987678)	Comments: Crashed when I hit send again.  
     (14987660)	Comments: It crashed when I hit send on an email

Comment 1

[Jay Patel [:jay]]

Adding crash, topcrash and qawanted keywords to see if anyone can reproduce
this.  I was going to make this a zt4newcrash bug since it looks like a
regression, but couldn't find any recent checkin that might be at fault around
the code of the crash.

Comment 2

[David Bradley]

This caught my eye, but I see no possible way for
nsTextServicesDocument::GetCurrentTextBlock to call
XPCCallContext::GetRetValPtr. My guess would be the stack was corrupted. Most
likely got corrupted by something GetCurrentTextBlock called. GC might have
happened, or maybe something in another thread, hard to say.

Comment 3

[Kathleen :Brade]

-->kin for triage/reassignment

Comment 4

[Jay Patel [:jay]]

There was another crash related to the spellchecker a while back...not sure if
it'll be much help, but it might be worth a look: bug 141560

Comment 5

[kinmoz]

I'm not exactly sure which spellchecker is being used or how people installed it
... note that there are 2 out there (Netscape7.0's spellchecker and the one on
MozDev.org). I believe [e-mail] made some interface changes to the
TextServices for bug 173046 so if these spellcheckers were compiled with the
older version of the TextServices interfaces and are being used with a recent
trunk build, you would definitely get problems like this.

My guess is that people that are generating these crashes are using the
mozdev.org spellchecker. The fix would be to recompile it against the trunk sources.

Comment 6

[kinmoz]

Marking invalid. The textservices api was changed. People will have to recompile
the spellchecker they are using against the new apis.

Comment 7

[Jay Patel [:jay]]

Verifying invalid.  Should we inform the people on mozdev.org about recompiling
the spellchecker with the latest MozillaTrunk source?

Comment 8

[David Bradley]

*** Bug 189530 has been marked as a duplicate of this bug. ***

Comment 9

[Paul F. Hubert]

*** Bug 189829 has been marked as a duplicate of this bug. ***

Comment 10

[Jay Patel [:jay]]

Adding nsTextServicesDocument::FirstBlock to summary...it's another stack
signature being reported by Talkback for these spellchecker crashes.

Comment 11

[R.K.Aa.]

*** Bug 191375 has been marked as a duplicate of this bug. ***

Comment 12

[Jay Patel [:jay]]

*** Bug 191788 has been marked as a duplicate of this bug. ***

Comment 13

[Jay Patel [:jay]]

Adding [@ spellchk.dll] for future reference.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Out of curiosity, would changing the IID of the interface that changed have
prevented the crashes?)

Comment 15

[David Bradley]

It might have made the problem more obvious. I suspect what would have happened
then, is that the code would have been looking for a non-existent IID. I'd have
to look to see what problems that cause.

Ideally adding new methods to the end of the interface is the safest.

Another option would be to create a new interface with a new IID, and have the
object support that as well. Then old clients could work with the older
interface, while clients needing the new functionality could use the new
interface. In the end, I think we really need to figure out what solution we
want to use for versioning.

Comment 16

[Jay Patel [:jay]]

Just wanted to make a note that this continues to be a problem with the
MozillaTrunk and Mozilla 1.3 (on the branch).  I see a few crashes already for
SPELLCHK.DLL and nsTextServicesDocument::FirstBlock with recent MozillaBranch
builds for the upcoming release. 

If we do plan to make any changes on how we deal with versioning (and prevent
these crashes)...we should reopen this bug.

Comment 17

[rubydoo123]

verify

Comment 18

[Honglin Su]

It is weired! I just uninstalled mozilla 1.3 (Windows NT) which had
spellchecker, and installed 1.3.1, it works fine. However, for my Linux
(Mandrake 9.0), 1.3.1 seems not happy with the spellchecker, it crashed
everytime when I started the spellcheck. So I have to use mozilla 1.4b.

Comment 19

[Jay Patel [:jay]]

Updating summary with M140B and [@ UTF8InputStream::Read] since this crash is
being reported under that signature as well.  This continues to be a topcrasher
for Mozilla 1.4 Beta...