185366 - error in test0.html

Status: RESOLVED FIXED

(Core Graveyard :: Viewer App, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

viewer startup shows this error:

CSS Error (resource:///res/samples/test0.html :11.14): Found trailing token
after pseudo-element, which must be the last part of a selector:  ':'.  Selector
expected.  Ruleset ignored due to bad selector.

line 11 is this:
 a:visited { color: red; }
character 14 is the 'c'

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

cc'ing some people who can maybe tell me what the error in that line is

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

a:first-line:visited { color: red; }

I have a bug on the fact that we count lines from the beginning of the style
element rather than the beginning of the HTML file.  At least I think I do...

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(Probably ":first-line a:visited" would work better anyway.)

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Er, never mind.  Pseudo-elements can only appear on the subject of the selector,
and :first-line only works on blocks, so you can't do that...

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch to remove that line

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 109303 [details] [diff] [review]
patch to remove that line

r+sr=roc+moz

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in.