185867 - shift delete doesn't work in the advanced search dialog [watch out for regressions]

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

shift delete doesn't work in the advanced search dialog

from SearchDialog.xul:

<!--
    commenting out until we figure this out.
    this is causing a bunch of key codes to map to shift delete
    see bug #185416
    <key id="cmd_shiftdelete" oncommand="goDoCommand('cmd_shiftdelete');"/>
-->

so the before we fix and re-enable the commented code, we have to figure out
that problem.

Comment 1

[(not reading, please use [e-mail] instead)]

as is, with that key commented out, I get:

###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/trees/trunk/mozilla/content/base
/src/nsDocumentViewer.cpp, line 2134

that is caused by cmd_cut not being handled I think.

using lxr, I see why shift delete maps to cmd_cut (but not why it doesn't for
the mail 3 pane).

this needs some more investigation.

when debugging with this code uncommented, a bunch of key codes mapped to shift
delete

Comment 2

[(not reading, please use [e-mail] instead)]

futuring.  this would be nice, but resources are limited.

note to self (or who ever implements this):

watch out for regressions, like bug #185416

Comment 3

[[e-mail]]

Attachment: Fixed case of cmd_shiftDelete

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 116058 [details] [diff] [review]
Fixed case of cmd_shiftDelete

using this version of the patch doesn't have dataloss regression that that I
introduce the first time, r/sr=sspitzer

Comment 5

[(not reading, please use [e-mail] instead)]

re-assign to neil.

Comment 6

[Sean Su]

Comment on attachment 116058 [details] [diff] [review]
Fixed case of cmd_shiftDelete

it works for me too.

late r=ssu

Comment 7

[[e-mail]]

Especially as I checked it in 2 weeks ago :-)