186999 - current record scrolls out of thread pane viewport after sort

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[john w]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130

Mozilla email using pop3 or imap inbox.  Close the body display window on the
right. Hightlight any message on the message list. Click any colunn head to
sort, such as the "Subject" colunn heading to sort by subject.  The current
record is not re-focused in the display window after the sort, requiring
scrolling down and down to find it.

Note, this problem does not exist if the body display window is opened. Somehow,
when the body display window is opened, and the current highlight record remains
in the display list after the sort is finished.

Reproducible: Always

Steps to Reproduce:
1.Close the body display window
2. Highlight any mail record in list
3. click some colunn head to initiate a sort
Actual Results:  
highlighted record is not refocused/centered into the screen.

Expected Results:  
The display of the sorted list should be vertically centered about the
hightlighted record so that it remains in the display after the sort is finished.

i classified this a major because I have a big inbox, and I use the sort feature
all the time.  I don't want to use the work-around (keeping the body display
window open) because I often want to delete groups of records without opening
them (eg, spam and suspected viruses).  Patiently using Netscape Communicator,
which does not have this problem, until this Mozilla problem can be fixed.  
Thanks!

Comment 1

[laurel]

This has been a problem on and off over versions... there are some open and
closed existing bugs on this.  Will dup them against this current version report
and nominate.

Comment 2

[laurel]

*** Bug 111665 has been marked as a duplicate of this bug. ***

Comment 3

[Felix Miata]

What a mess you make duping a new OS specific bug to a much older all all
blocking bug. This problem has never been gone since bug 111665 was filed.

Comment 4

[Samir Gehani]

Mail triage team: nsbeta1-

Comment 5

[R.K.Aa.]

*** Bug 199251 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Cowperthwaite]

Is this not a dupe of 94363?

Reporter (I believe) has refiled this bug as 194055.  I suggested it was a dupe 
there, too.

Comment 7

[Felix Miata]

*** Bug 194055 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Cowperthwaite]

*** Bug 186074 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Cowperthwaite]

Reducing severity to approprite level; fixing summary to refer to "thread pane" 
which is the correct name of the 'viewport' in question.

Note that bug 94363 has a patch under review which may address this issue.

Comment 10

[[e-mail]]

Attachment: Proposed patch

By adding extra parameters to save/restore I save/restore the key for the
current index rather than relying on the currently loaded message. This also
fixes the bug that selectMsgByKey also selects the loaded message, it now
guarantees to select only the message with the specified key.

Comment 11

[David :Bienvenu]

Comment on attachment 132188 [details] [diff] [review]
Proposed patch

nit: just fix the brace here:

+  if (aCurrentMsgKey) {
+    PRInt32 currentIndex;
+    if (NS_SUCCEEDED(mTreeSelection->GetCurrentIndex(&currentIndex)) &&
currentIndex >= 0 && currentIndex < GetSize())
+      *aCurrentMsgKey = m_keys.GetAt(currentIndex);
+    else
+      *aCurrentMsgKey = nsMsgKey_None;
+  }

Comment 12

[[e-mail]]

Comment on attachment 132188 [details] [diff] [review]
Proposed patch

Trying different reviewer.

Comment 13

[Mike Cowperthwaite]

Has this patch been checked in?  I'm seeing the correct behavior in 
  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031030

Comment 14

[Henry Jia]

This patch isn't in.

I can't reproduce this bug. Neil, any updates?

Comment 15

[Les Gasser]

This bug definitely still exists in the latest nightly
build which I just downloaded.

Mozilla 1.6b
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031110

Please see the detailed instructions for reproducing this bug
that appear in bug 111665. Note that you must have the "preview" window
completely "collapsed" to make this appear - see comment
#8 in bug 111665.

-- Les

Comment 16

[[e-mail]]

Comment on attachment 132188 [details] [diff] [review]
Proposed patch

Maybe Scott's new email address works better ;-)

Comment 17

[[e-mail]]

Fix checked in.

Comment 18

[[e-mail]]

*** Bug 94363 has been marked as a duplicate of this bug. ***