187059 - Shift+Ctrl+G (Find Previous) doesn't work

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Jesse Ruderman]

Ctrl+Shift+G for Find Previous doesn't work in Phoenix.  This is a problem with
both Edit>Find and typeahead find.  cf bug 171747 for F3.

Comment 1

[Jesse Ruderman]

I'm using a 12/27 build on Windows XP.

Comment 2

[David Tenser [:djst]]

Didn't know it was supposed to do that.

http://texturizer.net/phoenix/keyboard.html

Comment 3

[:deanis74]

Related to bug 184050?

Comment 4

[Blake Ross]

What programs use this shortcut?

Comment 5

[:deanis74]

Other than Mozilla?  I have no idea.  I'm fine toasting Ctrl[Shift+]G completely
and only supporting [Shift+]F3.

Comment 6

[noririty]

*** Bug 208597 has been marked as a duplicate of this bug. ***

Comment 7

[Win Bent]

As the "author" of a <A
HREF=http://bugzilla.mozilla.org/show_bug.cgi?id=208597#c5>related report</A>
for the same bug, I'm glad to see that A) they're not dropping Ctrl-Shift-G, and
B) there's a solution ready to go into the next release.

Comment 8

[Mike Connor [:mconnor]]

due to bug 186789, any Ctrl+Shift shortcuts won't work on GTK2 platforms, I
suggest that while we could implement this for backwards compatibility, no UI or
help files should reference this as it is not a cross-platform solution

Comment 9

[Mike Connor [:mconnor]]

Attachment: add Ctrl+Shift+G support back in

we support Ctrl+G, so we should support Ctrl+Shift+G

this won't work on GTK2 builds, per the bug I mentioned.

this also moves certain values from farther down the list in browser.dtd to
where they should be (with the rest of the find access/command keys)

Comment 10

[Mike Connor [:mconnor]]

-> taking

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 132170 [details] [diff] [review]
add Ctrl+Shift+G support back in

more for the pile

Comment 12

[:deanis74]

aside: I've always wondered why we allow the key to be modified in the .dtd but
hard-code the modifiers.

Comment 13

[:deanis74]

further aside: Maybe we should try and start the trend of putting the modifiers
into the .dtd as well.  Then you'd have |modifiers="&findPrevCmd.modifiers;|,
with a corresponding entry in the .dtd.  This would be much easier to localize,
in case there's a different standard for a shortcut key in another locale.  Any
thoughts?

Comment 14

[Mike Connor [:mconnor]]

maybe look at it in another bug, I'm not sure whether other locales do in fact
use different accesskeys (although if we did, that would probably cause more
headaches than anything if a localizer broke common shortcuts by using this)

Comment 15

[Pierre Chanial]

Ctrl-shift-G is the correct shortcut for linux: from the Gnome HIG (chapter 10,
keyboard navigation):

Use Shift-Ctrl-letter for functions that reverse or extend another function. For
example, Ctrl-Z and Shift-Ctrl-Z for Undo and Redo. Note that you cannot use
Shift-Ctrl-A-thru-F, however, as these combinations are used to enter unicode
characters in text fields.

Comment 16

[Pierre Chanial]

Comment on attachment 132170 [details] [diff] [review]
add Ctrl+Shift+G support back in

r=me, but there was no need to add <!ENTITY findPrevCmd.commandkey "g">, you
could have reused findAgainCmd.commandkey

Comment 17

[Pierre Chanial]

fixed