187322 - favicon.ico drawing code prefers 8-bit icons over 32-bit icons even on deep displays

Status: RESOLVED WONTFIX

(Camino Graveyard :: General, defect)

Description

[Charles Wiltgen]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.0.1) Gecko/20021231 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.0.1) Gecko/20021231 Chimera/0.6+

When you go to http://playbacktime.com/, you *should* see a 32-bit favicon (with
a nice, alpha-masked edge) when using a display mode greater than 8 bits per
channel.

Instead, the favicon.ico drawing code is drawing the 256-color icon in
favicon.ico even though a 32-bit icon is available.  Apparently, the favicon.ico
drawing code gives precendence to 8-bit icons over 32-bit icons.  The 32-bit
icon should be drawn (with its alpha mask) in this case.

As a workaround, I'm going to have to faux-anti-alias the 256-color icon against
white.  This means the icon won't look quite right against non-white backgrounds.

Reproducible: Always

Steps to Reproduce:
1. Create a favicon.ico file with 8-bit and 32-bit icons.
2. Put the favicon.ico file in the root folder of your site.
3. Go to that site.

Actual Results:  
The 8-bit icon is displayed.

Expected Results:  
The 32-bit icon can and should be displayed.

Using latest nightly build of Chimera.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

hmm, right... this was never fixed on the 1.0 branch of mozilla...

this would be a duplicate of bug 109862. It was fixed on May 14 last year on the
mozilla trunk.

if you want this to get checked in on the 1.0 branch as well, please comment in
that bug.

marking duplicate.

*** This bug has been marked as a duplicate of 109862 ***

Comment 2

[Sören 'Chucker' Kuklau (gone)]

As this bug is not critical for Gecko 1.0.x stability, I doubt it will be fixed
in the Mozilla 1.0.x. Chimera is not on the 1.0 branch though, but on the
"CHIMERA_M1_0_1_BRANCH", so we can add addition patches, and imho, this should
be one of them. Therefore reopening.

Comment 3

[Sören 'Chucker' Kuklau (gone)]

And confirming.

Comment 4

[Simon Fraser [no longer active]]

Er, Chimera doesn't use the Mozilla favicon code at all. Chimera just throws the
favicons at NSImage, so this would be a Cocoa bug. File a bug with Apple.