187442 - change PL_strcmp to strcmp in nsIOService

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[timeless]

nsIOService::SetOffline for the going offline case does this:

mOffline = PR_TRUE;		// indicate we're trying to shutdown
// don't care if notification fails
observerService->NotifyObservers(...,"network:offline-about-to-go-offline",...);
// be sure to try and shutdown both (even if the first fails)
rv1 = mDNSService->Shutdown();  // shutdown dns service first, because it has
callbacks for socket transport
rv2 = mSocketTransportService->Shutdown();
if (NS_FAILED(rv1)) return rv1;
if (NS_FAILED(rv2)) return rv2;
// don't care if notification fails
observerService->NotifyObservers(...,"network:offline-status-changed",...);

This means that if one of the two services fail to shutdown any observer that
happens to listen for this stuff will think it's still in about to go offline.

--

nsIOService::Observe for ... NS_XPCOM_SHUTDOWN_OBSERVER_ID:

SetOffline(PR_TRUE);
mFileTransportService->Shutdown();
// Break circular reference.
mProxyService = nsnull;

Ok, so what does it this observer do? we're in XPCOM shutdown, but it feels it's
a good idea to call SetOffline.
SetOffline of course needs to create the observer service to do anything useful.
That of course *fails* because xpcom has stopped allowing access to getService.

Comment 1

[timeless]

Attachment: cleanup

Comment 2

[Darin Fisher]

Comment on attachment 110490 [details] [diff] [review]
cleanup

some of this has been done, but some parts of this patch look like they could
still be useful.  care to rev the patch?  thanks in advance!

Comment 3

[timeless]

Attachment: remnant

well, the logic changed, so all that's left is a useless change

Comment 4

[timeless]

Comment on attachment 126139 [details] [diff] [review]
remnant

if you don't want it feel free to kill the bug

Comment 5

[Darin Fisher]

Comment on attachment 126139 [details] [diff] [review]
remnant

oh, is that all that's left?  heh, ok... r+sr=darin ;)

Comment 6

[timeless]

checked in

Comment 7

[benc]

V:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsIOService.cpp&branch=&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&rev1=1.161&rev2=1.162