Closed Bug 187819 Opened 22 years ago Closed 22 years ago

Cleanup nsImageWin::Draw

Categories

(Core Graveyard :: Image: Painting, defect)

Product:
Core Graveyard
Component:
Image: Painting
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.4alpha

People

(Reporter: paper, Assigned: paper)

Details

Attachments

(2 files, 2 obsolete files)

Cleanup Patch
12.69 KB, patch
smontagu
: review+
roc
: superreview+
Details | Diff | Splinter Review
Cleanup -w
10.36 KB, patch
Details | Diff | Splinter Review 
nsImageWin::Draw can be in a much more readable state with a bit of code
formatting.  Plus I think I see some dead code in there.
Attached patch Cleanup (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Cleanup -w (obsolete)
        — 
          — Splinter Review
      

    


  

    
    

    
  
Comment on attachment 111469 [details] [diff] [review]
Cleanup

smontagu, I choose you!
Use your reviewing powers against the evil unclean code, smontagu!

        Attachment #111469 -
        Flags: review?(smontagu)

    
  
Target Milestone: --- → mozilla1.4alpha

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Cleanup Patch
        — 
          — Splinter Review
      

    


  
unbitrotted

        Attachment #111469 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Cleanup -w
        — 
          — Splinter Review
      

    


  

        Attachment #111470 -
        Attachment is obsolete: true

    
  

        Attachment #111469 -
        Flags: review?(smontagu)

    
    

    
  
Comment on attachment 113180 [details] [diff] [review]
Cleanup Patch

patch should apply now

        Attachment #113180 -
        Flags: review?(smontagu)

    
    

    
  
Comment on attachment 113180 [details] [diff] [review]
Cleanup Patch

r=smontagu. I think there is more cleanup to do here, but small moves are good.

        Attachment #113180 -
        Flags: review?(smontagu) → review+

    
    

    
  
Comment on attachment 113180 [details] [diff] [review]
Cleanup Patch

a simple cleanup patch. Could you SR, roc?

        Attachment #113180 -
        Flags: superreview?(roc+moz)

        Attachment #113180 -
        Flags: superreview?(roc+moz) → superreview+

    
    

    
  
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: