187907 - Expr::toString should be removed or debug-only

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We should not use Expr::toString when outputting error-messages. Once we start
optimizing XPath-expressions there is no way we can recreate the
expression-string to something that is close to what the user typed.

So the question is, do we want to remove Expr::toString entierly, or do we wanna
keep it around for debugging-purposes?

MSVC can show the complete object-tree from just an Expr*, so I don't really
need ::toString, don't know about gdb/CodeWarrior though.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Peterv: you mentioned some time ago that you had something in mind for this?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

reassining bugs i'm not working on to default owner

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v1

I tried this and it saves about 8k on codesize in my OS X optimized build. I've
put it under a define that's turned on in debug builds, but I don't mind
removing the code completely. Objections?

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Either way is fine with me

Comment 5

[Axel Hecht]

Comment on attachment 147450 [details] [diff] [review]
v1

put the mSerialize of the Root pattern and expr into the ifdef, too. and no two
#ifdefs in txErrorFunctionCall.
With that, r=me.

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: v1.1

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 147621 [details] [diff] [review]
v1.1

sr=jst