1880438 - Check if nsGlobalWindowInner::ExecuteIdleRequest should refuse requests when ProcessChild::ExpectingShutdown

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, task)

Description

[Jens Stutte [:jstutte]]

See the stack from bug 1880427 comment 0. There might be nicer ways than just checking ProcessChild::ExpectingShutdown (like a shutdown blocker and own shutdown flag or some such). But ProcessChild::ExpectingShutdown can be set asynchronously without main thread processing and is the earliest signal we can get, IIRC.

Comment 1

[Jens Stutte [:jstutte]]

Note that there is no proof from that specific stack that at the moment we entered nsGlobalWindowInner::ExecuteIdleRequest we were already asked to shut down, but it seems advisable to avoid idle processing in such a situation.

Comment 2

[Jens Stutte [:jstutte]]

Let's see if doing this breaks something obvious.

Comment 3

[Jens Stutte [:jstutte]]

Attachment: Bug 1880438 - Make nsGlobalWindowInner::ExecuteIdleRequest refuse to execute requests after ProcessChild::ExpectingShutdown. r?#dom-core-reviewers

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I'm still a bit confused why we want to do anything special with idle tasks, but not other pending tasks (which have been also scheduled by a web page). Is it just because we happened to see idle tasks on a stack?

Comment 5

[Jens Stutte [:jstutte]]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #4)

I'm still a bit confused why we want to do anything special with idle tasks, but not other pending tasks (which have been also scheduled by a web page). Is it just because we happened to see idle tasks on a stack?

The assumption was that idle tasks on an inner window are not important enough to ensure they are executed once dispatched. That might be a misconception, though. Most of the requestIdleCallback tasks I've seen seem to fall into this category, FWIW, but it might be an inappropriate shortcut I want to take here.

Comment 6

[Jens Stutte [:jstutte]]

Is it just because we happened to see idle tasks on a stack?

And yes, there is no real deeper understanding here from my side other than stumbling over these idle callbacks through that stack...