188247 - Build LDAP with GCC 3.x on OS/2

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[jhp (no longer active)]

Derived from Meta bug 177789.  This bug deals specifically with patches to make
LDAP build on OS/2 using GCC 3.0.3.

Comment 1

[jhp (no longer active)]

Attachment: preliminary patch

First patch.  LDAP builds as part of Mozilla, but has not been tested.

Comment 2

[jhp (no longer active)]

Attachment: patch v2

General code cleanup.

Comment 3

[jhp (no longer active)]

Attachment: patch v2.1

Define BSD_SELECT in the correct place.

Comment 4

[jhp (no longer active)]

Attachment: patch v2.2

More cleanup.

Comment 5

[jhp (no longer active)]

Attachment: patch v2.3

Cleanup

Comment 6

[Mark Smith [:mcs]]

Comment on attachment 118056 [details] [diff] [review]
patch v2.3

I am not an expert on configure, but this change worries me a little:

@@ -459,7 +459,7 @@
 if test "$GXX" = "yes"; then
     GNU_CXX=1
 fi
-if test "`echo | $AS -V 2>&1 | grep -c GNU`" != "0"; then
+if test "`echo | $AS -v 2>&1 | grep -c GNU`" != "0"; then
     GNU_AS=1
 fi
 rm -f a.out

This affects all platforms, right? At least for some versions of as (e.g.,
Sun's) -v fails but -V works.

Comment 7

[jhp (no longer active)]

That's quite interesting.  For us, "-V" doesn't work, but "-v" does.  The issue
that I was having (if I am recalling this correctly) was that "-pipe" support
was not getting set for NSPR and LDAP, but was working in the browser tree. 
Eventually, with Seawood's help, we noticed that the browser configure.in used
"-v", while NSPR and LDAP used "-V".  So does Sun have a problem with the
browser configure.in?

Comment 8

[jhp (no longer active)]

Attachment: patch v2.4

Fix Visual Age bustage.

Comment 9

[Mark Smith [:mcs]]

As far as I know there are no problems related to the browser configure.in on
Solaris... I suppose it would only show up if you do not use the GNU tools,
which most people do.

Comment 10

[Mark Smith [:mcs]]

Comment on attachment 118078 [details] [diff] [review]
patch v2.4

OK.

Comment 11

[jhp (no longer active)]

Comment on attachment 118078 [details] [diff] [review]
patch v2.4

Seeking sr= for checkin into branch

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 118078 [details] [diff] [review]
patch v2.4

sr=dmose

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Note that a generated configure needs to be checked in as well.

After you've landed this on the LDAP client branch, please reassign to me or mcs
and one of us will land it on the LDAP trunk so that these changes don't get
lost whenever we decide to move to a new client branch.

Comment 14

[Mike Kaply [:mkaply]]

I checked in everything except the generated configure.

I grabbed the "correct" autoconf from cygwin, but it did not generate a
configure that corresponded to the configure that the Mozilla build is generating.

I need to take to cls about getting the right version of autoconf.

This shouldn't matter from a Mozilla build perspective. I will get this resolved
today.

Comment 15

[Frankie]

Spam for bug 129472

Comment 16

[Mark Smith [:mcs]]

Let me know when the generated configure is checked into
ldapcsdk_50_client_branch and then I will commit all of this to the trunk.

Comment 17

[jhp (no longer active)]

Mark:  For whatever reason, we could never generate a correct configure script.
 We used multiple versions of autoconf, all of which produced vastly different
files than what is currently checked in.  It has been a while, so I don't know
if someone already checked in an updated configure.  If this is not the case,
could you check in the generated configure script for us? 

Comment 18

[Mark Smith [:mcs]]

Unfortunately I am not sure I can generate the correct configure script. I'll
give it a try when I get a chance.

Comment 19

[jhp (no longer active)]

Marking this fixed, since the changes to configure.in have now been incorporated
into later versions of configure.

Comment 20

[Mike Kaply [:mkaply]]

I don't think this ever got checked in on the LDAP trunk...

Comment 21

[cls]

The patch has been checked in on the ldap trunk now.