188597 - for xul:textbox; CSS's property "text-align" does nothing;

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Ariel Fatecha]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130

if you have a xul:textbox and a sytlesheet with a property:
"text-align: right;" nothing happens, because html:input doesn't have:
"text-align: inherit;"

Reproducible: Always

Steps to Reproduce:
1. in XUL: <textbox class="mytxt" value="hi,man"/>
2. in CSS: .mytxt { text-align: right;}
3. Nothing happens.
Actual Results:  
text is left aligned yet.

Expected Results:  
in all textbox.css (modern and classic) add a single line:
  text-align: inherit;
into:
  html|textbox-input,
  html|textbox-textarea{
    ...
    text-align: inherit; /* new line */
  }

Comment 1

[Ariel Fatecha]

Attachment: testcase

this file has a textbox and a button, button change an attribute into the
textbox.
it's all.
the problem is in css.
need bug188597.css.

Comment 2

[Ariel Fatecha]

Attachment: testcase

this file need bug188597.xul
contain the real problem.
Solution required add one line in every textbox.css
html|input{
  ... 
  text-align: inherit; //added
}

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah, adding that to either textbox.css or just as an inline style rule in the
XBL binding would make sense.... (I almost favor the latter over the former
since then theme authors don't have to deal with this....)

Comment 4

[John Morrison]

*** Bug 81060 has been marked as a duplicate of this bug. ***

Comment 5

[jag (Peter Annema)]

Couldn't we put that in xul.css, or a toolkit/global textbox.css?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yeah, that would be better than inline style.  ;) Either of those is good with me.

Comment 7

[Ariel Fatecha]

isn't closed?, ok, I'll post the proposed patch, inserting line in xul.css, like
said jag(Peter Annema)

Comment 8

[Ariel Fatecha]

Attachment: patching xul.css

adding: text-align: inherit;

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 114093 [details] [diff] [review]
patching xul.css

As the file says, one of the reviewers needs to be hyatt (@apple.com, not
@netscape.com).  Pleaes mail him personally; he does not read bugmail.

Comment 10

[jag (Peter Annema)]

Comment on attachment 114093 [details] [diff] [review]
patching xul.css

r=jag. Looks good to me. hyatt?

Comment 11

[Ariel Fatecha]

hyatt is busy

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 114093 [details] [diff] [review]
patching xul.css

sr=jst

Comment 13

[Ariel Fatecha]

patch is r+ and sr+.
Questions:
what now?
can I check it into the tree? 
change resolution to "fixed"?

Comment 14

[Boris Zbarsky [:bzbarsky]]

If you want it for 1.4b or 1.4, you need to request a= (see the options when you
edit the attachment).  If for 1.5a, ask someone to check it in for you once the
tree reopens.

Comment 15

[Ariel Fatecha]

Comment on attachment 114093 [details] [diff] [review]
patching xul.css

thanks :)

Comment 16

[Ariel Fatecha]

ok, patch has approval1.4b+
sorry, but more questions:
change resolution to "fixed"?
when is the patch inserted into the tree?

Comment 17

[Boris Zbarsky [:bzbarsky]]

When someone checks it in.  I'll try to do that tonight.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 19

[Ariel Fatecha]

thanks... :)